Build/ Update ember to 3.18 #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlueCutOfficial
force-pushed
the
build/update-ember-to-3.16
branch
from
f95def9
to
1d7ed08
Compare
BlueCutOfficial
force-pushed
the
build/update-ember-to-3.16
branch
from
1d7ed08
to
8fa64cd
Compare
BlueCutOfficial
commented
Aug 21, 2020
| "eslint-config-peopledoc": "^2.0.1", | ||
| "loader.js": "^4.7.0", | ||
| "npm-run-all": "^4.1.5", |
There was a problem hiding this comment.
@GreatWizard can I have your opinion on this? Apparently this dependency has been added when preparing the CI config for 3.18 (#33), but now that I actually lauch ember-cli-update, npm-run-all has been deleted automatically and the commands above reset to a more standard state. Can you explain a bit what it was about?
Note that I first open the PR because your commit about 3.18 was starting by "ci:", so I just haven't seen it, I thought we were still on 3.12. It would be nice to not mess up CI and actual updates in commit wording...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.