Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade add-on to Ember.js v5.8.1 #190

Merged
merged 9 commits into from
Jul 9, 2024
Merged

Upgrade add-on to Ember.js v5.8.1 #190

merged 9 commits into from
Jul 9, 2024

Conversation

MrChocolatine
Copy link
Member

@MrChocolatine MrChocolatine commented May 3, 2024 •
edited
Loading

Breaking

Upgrade add-on to ember-cli v5.8.1 (#190)

The new requirements are:

  • Ember.js v4.12 or above
  • Ember CLI v4.12 or above
  • Node.js v18 or above

Resolves #172 .

Closes #171 .
Closes #174 .
Closes #187 .
Closes #188 .
Closes #189 .

@MrChocolatine MrChocolatine added dependencies Pull requests that update a dependency file breaking Breaking changes labels May 3, 2024
@MrChocolatine MrChocolatine force-pushed the upgrade-emberjs-to-latest branch 3 times, most recently from 3b47671 to c68d297 Compare May 5, 2024 20:15
@MrChocolatine MrChocolatine marked this pull request as ready for review May 5, 2024 20:25
@MrChocolatine MrChocolatine requested a review from a team as a code owner May 5, 2024 20:25
@MrChocolatine MrChocolatine changed the title DRAFT // Upgrade Ember.js to v5.8.1 Upgrade add-on to Ember.js v5.8.1 May 5, 2024
@MrChocolatine MrChocolatine marked this pull request as draft May 15, 2024 07:35
@MrChocolatine MrChocolatine marked this pull request as ready for review May 17, 2024 08:15
This was referenced May 18, 2024
Closed
Closed
Closed
This was referenced May 25, 2024
Closed
Closed
@MrChocolatine
Copy link
Member Author

Can we move forward or I close this PR.

BlueCutOfficial
BlueCutOfficial approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@BlueCutOfficial BlueCutOfficial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was simply waiting for the revert I requested, the rest was all good to me.

@BlueCutOfficial BlueCutOfficial merged commit 183b598 into master Jul 9, 2024
9 checks passed
@BlueCutOfficial BlueCutOfficial deleted the upgrade-emberjs-to-latest branch July 9, 2024 08:07
@MrChocolatine MrChocolatine mentioned this pull request Sep 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlueCutOfficial BlueCutOfficial BlueCutOfficial approved these changes

Assignees
No one assigned
Labels
breaking Breaking changes dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade Node.js to version >= 18
2 participants
@MrChocolatine @BlueCutOfficial