refactor: modernise Helper as a plain function

https://blog.emberjs.com/plain-old-functions-as-helpers/
DazzlingFugu · Jul 8, 2024 · a0cd7de · a0cd7de
1 parent cf1b5b2
commit a0cd7de
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/addon/helpers/reading-time.js b/addon/helpers/reading-time.js
@@ -1,10 +1,9 @@
-import { helper } from '@ember/component/helper';
 import readingTime from 'reading-time';
 import humanizeDuration from 'humanize-duration';
 
-export default helper(function helperReadingTime(positional /*, named*/) {
-  const stats = readingTime(String(positional[0]));
-  const userOptions = positional[1];
+export default function helperReadingTime(value, options) {
+  const stats = readingTime(String(value));
+  const userOptions = options ?? {};
 
   const defaultOptions = {
     round: true,
@@ -17,4 +16,4 @@ export default helper(function helperReadingTime(positional /*, named*/) {
     stats.time < 60000 ? 60000 : stats.time,
     Object.assign({}, defaultOptions, userOptions),
   );
-});
+}
diff --git a/app/helpers/reading-time.js b/app/helpers/reading-time.js
@@ -1 +1 @@
-export { default, readingTime } from 'ember-reading-time/helpers/reading-time';
+export { default } from 'ember-reading-time/helpers/reading-time';