Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to ember 3.28 #10

Merged
merged 2 commits into from
Oct 18, 2021
Merged

feat: upgrade to ember 3.28 #10

merged 2 commits into from
Oct 18, 2021

Conversation

GreatWizard
Copy link
Member

@GreatWizard GreatWizard commented Oct 7, 2021

Build

Upgrade to ember v3.28 (#10)

This PR must be considered as breaking:

  • Drop node 10 support
  • Need ember-cli and ember-source as v3.20+

@GreatWizard GreatWizard requested a review from a team as a code owner October 7, 2021 14:36
Copy link
Member

@BlueCutOfficial BlueCutOfficial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe mark it breaking (remove tests support in CI), else LGTM

Copy link
Member

@MrChocolatine MrChocolatine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blocking at all, but still asking the question, do we want to keep testing for ember-beta and ember-canary?


This comment is not relevant anymore, see DazzlingFugu/ember-feature-controls#153 (comment) .

@MrChocolatine MrChocolatine added the dependencies Pull requests that update a dependency file label Oct 18, 2021
@MrChocolatine MrChocolatine merged commit be75bb9 into master Oct 18, 2021
@MrChocolatine MrChocolatine deleted the feat/upgrade-3-28 branch October 18, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants