feat: upgrade to ember 3.28 #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GreatWizard
force-pushed
the
feat/upgrade-3-28
branch
3 times, most recently
from
b1e0a9b
to
673e495
Compare
GreatWizard
force-pushed
the
feat/upgrade-3-28
branch
from
673e495
to
638956f
Compare
BlueCutOfficial
approved these changes
Oct 8, 2021
Comment on lines
+35
to
+49
| name: 'ember-beta', | ||
| npm: { | ||
| devDependencies: { | ||
| 'ember-source': await getChannelURL('beta'), | ||
| }, | ||
| }, | ||
| }, | ||
| { | ||
| name: 'ember-canary', | ||
| npm: { | ||
| devDependencies: { | ||
| 'ember-source': await getChannelURL('canary'), | ||
| }, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Do we really to add back the scenarios beta and canary? (see #139)
I thought we wanted to get rid of these from all our Ember.js projects.
There was a problem hiding this comment.
It's not in the CI, juste configured in try
I don't see any reasons to not keep it here for the future ^^ as long as it's disabled on the CI
There was a problem hiding this comment.
Ah my bad, I went too fast and thought the CI would run again these 2 scenarios.
|
We already dropped the support for Node.js v10 in #139, so you can remove the line
from the description of your PR. |
MrChocolatine
approved these changes
Oct 11, 2021
This was referenced Oct 12, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build
Upgrade to ember v3.28 (#153)
This PR must be considered as breaking: