Improve catchup script #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlueCutOfficial
force-pushed
the
improve-catchup-script
branch
from
263038e
to
9a19a1c
Compare
BlueCutOfficial
force-pushed
the
improve-catchup-script
branch
from
9a19a1c
to
13bbe11
Compare
BlueCutOfficial
force-pushed
the
improve-catchup-script
branch
2 times, most recently
from
fef1d3f
to
bdf1ea3
Compare
…anch and update the English branch we need to compare current Ember version and new Ember version
…ef-upstream and upstream/master and parse it as an array of filenames
…arguments to the script
…o create for each changed file
…tions required at the end of the process
…iles in the script/patches folder
…to track the files to post in a GitHub issue
…les to create the diff files
…e need to do this because we want to do a replacement in the content
…e filename and from the content of the diff
…e updated path, so the file can be patched in our architecture
…f git apply fails (file translated), then we add to filesToPost to open a GitHub issue later
…ction so we know if there are patch files to commit and push
…t requires to read the secret token.
…n file and diff. There's no diff block if the file is new
…ssue for a given file
… the GitHub issues
…ally, push the changes on GitHub
…ss. One reset ref-upstream then the other will switch back to master or the catchup branch depending on the situation
… only if we no longer need the current state (all operations to create/edit diff files are ok), and switch back to the best branch
BlueCutOfficial
force-pushed
the
improve-catchup-script
branch
from
bdf1ea3
to
7f63c73
Compare
… ends with code 1
BlueCutOfficial
force-pushed
the
improve-catchup-script
branch
from
7f63c73
to
facdee3
Compare
GreatWizard
reviewed
Jan 10, 2024
|
|
||
| } catch (error) { | ||
| console.error('Failed to push the catchup branch.'); |
GreatWizard
approved these changes
Jan 10, 2024
GreatWizard
reviewed
Jan 10, 2024
| @@ -1,201 +1,282 @@ | |||
| import 'dotenv/config'; | |||
| import fetch from 'node-fetch'; | |||
| import { execSync } from 'child_process'; | |||
| import fs from 'fs'; | |||
| import minimist from 'minimist-lite'; | |||
There was a problem hiding this comment.
You hsould consider using
https://www.npmjs.com/package/command-line-args
https://www.npmjs.com/package/command-line-usage
const commandLineArgs = require('command-line-args');
const commandLineUsage = require('command-line-usage');
They are more nice for dev experience and you can print the help text easily
|
I need to merge the PR to finalize my blog post and have the link to the up-to-date script. But I'll keep issue #220 open to handle the comments. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #220