Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve automation script #220

Open
4 tasks done
BlueCutOfficial opened this issue Dec 9, 2023 · 2 comments
Open
4 tasks done

Improve automation script #220

BlueCutOfficial opened this issue Dec 9, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@BlueCutOfficial
Copy link
Member

BlueCutOfficial commented Dec 9, 2023

We have a first iteration of the automation script to sync with the latest English docs automatically. I was mainly focused on getting it to work, it could be cleaner:

  • Abstract the usage of shell into a function
  • Follow @GreatWizard's comments in Catch up latest docs: from 5.1 to 5.4 #215
  • The script does not manage "new" files that have been correctly auto-applied because they didn't exist before (for example, typescript folder when upgrading from 5.1 to 5.4), these should not contain any diff.

EDIT: It's a lot better than before, there are 2 new comments to handle in #236:

  • Use console.warn for errors that are not re-throw
  • Use better tools to parse the script arguments
@BlueCutOfficial
Copy link
Member Author

I rewrote everything with more modern syntaxes on a test repo, so I keep the issue open until I update.
See https://mainmatter.com/blog/2024/01/30/ember-guides-fr-git-automation/

@BlueCutOfficial
Copy link
Member Author

I need to add a --no-verify in the commit command because modified English files are staged but are not expected to be added in .remarkignore, it makes the script fail for no reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant