Catch up latest docs: from 5.1 to 5.4 #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlueCutOfficial
force-pushed
the
catchup-5.4
branch
2 times, most recently
from
aa7d5d3
to
65619d3
Compare
BlueCutOfficial
force-pushed
the
catchup-5.4
branch
from
65619d3
to
866c4c8
Compare
GreatWizard
reviewed
Dec 9, 2023
| \`\`\`diff | ||
| ${diffblock} | ||
| \`\`\` | ||
| `, |
GreatWizard
reviewed
Dec 9, 2023
| }); | ||
|
|
||
| // Create a directory to put the children diff | ||
| fs.mkdirSync('scripts/patches'); |
There was a problem hiding this comment.
To avoid issues if the dir already exists you can set recursive option:
Suggested change
| fs.mkdirSync('scripts/patches'); | |
| fs.mkdirSync('scripts/patches', { recursive: true }); |
GreatWizard
reviewed
Dec 9, 2023
| } | ||
| console.log('shelljs: "git push origin -f ref-upstream" executed'); | ||
|
|
||
| if (shell.exec('git switch master').code !== 0) { |
There was a problem hiding this comment.
What about a shell/exec function like this and use it everywhere:
function shellexec(command){
if (shell.exec(command).code !== 0) {
throw new Error(`shelljs: "${command}" command failed`);
}
console.log(`shelljs: "${command}" executed`);
}
GreatWizard
reviewed
Dec 9, 2023
|
|
||
| if (!issuePostingError) { | ||
| // Once the issues are posted, delete patches folder and files | ||
| fs.rmSync('scripts/patches', { recursive: true, force: true }); |
There was a problem hiding this comment.
Should be better with a main try/catch and then do the rmSync in the finally
GreatWizard
approved these changes
Dec 9, 2023
|
=> #220 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic catch up PR to align our non-translated documentation with the latest official documentation.