Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v4.0.0 #180

Merged
merged 2 commits into from
Apr 12, 2022
Merged

Release v4.0.0 #180

merged 2 commits into from
Apr 12, 2022

Conversation

GreatWizard
Copy link
Member

@GreatWizard GreatWizard commented Jan 21, 2022

Breaking change

ember-local-storage v2 (#167)

ember-local-storage dependency has been updated to v2. Be aware about potential side effect on your application.
See ember-local-storage changelog.

Refactor

Glimmer migration (#179)

Build

Whitelist files to include when publishing (#172)
Uninstall contributor-faces (#170)

Dev-dependencies

Doc

Auto-update list of contributors (#171)

CI

New workflow to auto-update list of contributors (#170)

@GreatWizard GreatWizard requested a review from a team as a code owner January 21, 2022 11:15
@GreatWizard GreatWizard marked this pull request as draft January 21, 2022 11:16
@GreatWizard GreatWizard marked this pull request as ready for review January 21, 2022 11:26
Copy link
Member

@MrChocolatine MrChocolatine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I added the following to your description:
- bump ember-try from 1.4.0 to 2.0.0 (#174)
  1. Should breaking: update to ember-local-storage v2 #167 be considered a breaking change or not? (since you flagged your commit as "breaking" but not the PR)

@MrChocolatine
Copy link
Member

Plip plop

Copy link
Member

@BlueCutOfficial BlueCutOfficial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should release this as a patch. We updated a dep to a new major version.

@BlueCutOfficial BlueCutOfficial dismissed their stale review April 12, 2022 14:37

Tag fixed to 4.0.0 with @GreatWizard blessing

@BlueCutOfficial BlueCutOfficial merged commit c00368e into master Apr 12, 2022
@BlueCutOfficial BlueCutOfficial deleted the release/v3.0.1 branch April 12, 2022 14:43
@BlueCutOfficial BlueCutOfficial changed the title Release v3.0.1 Release v4.0.0 Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants