Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: glimmer migration #179

Merged
merged 1 commit into from
Jan 19, 2022
Merged

refactor: glimmer migration #179

merged 1 commit into from
Jan 19, 2022

Conversation

GreatWizard
Copy link
Member

@GreatWizard GreatWizard commented Jan 17, 2022

Refactor

Glimmer migration (#179)

  • Use glimmer component for the feature-controls component
  • Use anglebracket syntax in tests
  • Refactors test in order to mock services more clearly
  • Prevent _normalizeFlag function to be renamed/removed in features service by adding a fallback to camelize
  • Rename service feature-control-storage into feature-controls-storage (typo)
  • Split acceptance tests depending of the context (localstorage or not)

@GreatWizard GreatWizard force-pushed the feat/glimmer-migration branch 6 times, most recently from f2e222f to dc1d852 Compare January 18, 2022 15:24
@GreatWizard GreatWizard marked this pull request as ready for review January 18, 2022 15:24
@GreatWizard GreatWizard requested a review from a team as a code owner January 18, 2022 15:25
@GreatWizard GreatWizard force-pushed the feat/glimmer-migration branch 2 times, most recently from 36ed1df to 94f1ec1 Compare January 18, 2022 15:53
@MrChocolatine
Copy link
Member

MrChocolatine commented Jan 18, 2022

-- Friendly remark --

In general ...args should be preferred over ...arguments, even if by convention the latter is used in Ember.js.
Reminder: arguments is not a real Array, ...args is.

package.json Outdated Show resolved Hide resolved
@GreatWizard GreatWizard merged commit 56b2fe8 into master Jan 19, 2022
@GreatWizard GreatWizard deleted the feat/glimmer-migration branch January 19, 2022 08:58
@GreatWizard GreatWizard mentioned this pull request Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants