[JS-951] fix: use ember-local-storage for both read & write FF #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,6 @@ | |||
| import Service from '@ember/service' | |||
There was a problem hiding this comment.
Am I right saying that you created this Service, with only 1 property, just to make it easier to mock it during tests?
There was a problem hiding this comment.
Nope, the purpose of this property is to be read from instance-initializers/load-feature-controls.js & keeping consistency between read & write on local-storage....
In other words, I didn't find the way to properly take into account the ember-local-storage settings in instance-initializers when reading from local-storage without using this service...
Comment on lines
+11
to
19
| let { content: featureControls } = controlStorageService.get('featuresLS') | ||
| if (featureControls) { | ||
| Object.keys(featureControls).forEach(flag => { | ||
| if (features.get("flags").includes(flag)) { | ||
| featureControls[flag] ? features.enable(flag) : features.disable(flag) | ||
| } | ||
| }) | ||
|
|
||
| } |
There was a problem hiding this comment.
Simple suggestion not necessary of course 👍🏻 .
-
Without
if -
Direct access to flags value with
Object.entries()
But I admit it is less supported thanObject.keys.
Suggested change
| let { content: featureControls } = controlStorageService.get('featuresLS') | |
| if (featureControls) { | |
| Object.keys(featureControls).forEach(flag => { | |
| if (features.get("flags").includes(flag)) { | |
| featureControls[flag] ? features.enable(flag) : features.disable(flag) | |
| } | |
| }) | |
| } | |
| let featureControls = controlStorageService.get('featuresLS').content ?? {} | |
| Object.entries(featureControls).forEach(([ flag, flagValue ]) => { | |
| if (features.flags.includes(flag)) { | |
| flagValue ? features.enable(flag) : features.disable(flag) | |
| } | |
| }) |
MrChocolatine
approved these changes
May 5, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Use
ember-local-storagefor both read & write FF to prevent issue whenember-local-storageoptions differents from default (#112)This fix #111