[JS-951] ember-local-storage config is not correctly handle when not default

[romgere]

Features values are not correctly restored by instance-initializer when ember-local-storage is used with namespace or keyDelimiter options.

The reason is :

feature-controls component uses storageFor from ember-local-storage to write values in locale Store (https://github.com/peopledoc/ember-feature-controls/blob/master/addon/components/feature-controls.js#L6).
storageFor take into account the ember-local-storage config to write the key at the right place in locale storage (with correct namespace and/or delimiter).

In other hand, the instance initializer uses getStorage & get value with the storage:feature-controls key wich does not take into account the ember-local-storage config (https://github.com/peopledoc/ember-feature-controls/blob/master/addon/instance-initializers/load-feature-controls.js#L9)

It results with a desynchronisation between ember-feature-controls & ember-feature-flags as the value are not correctly restored onto ember-feature-flags features service.

[BlueCutOfficial]

@romgere can you create a JIRA ticket on Tribe JS board? 🙏

[romgere]

Sure I will

[romgere]

Done : JS-951