Align design system badge subtleties with Figma - #145
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d74bbbf937
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ), | ||
| neutral: cn( | ||
| "bg-button-neutral shadow-black/5 active:bg-button-neutral/90", | ||
| "border-border border-hairline bg-button-neutral shadow-black/5 active:bg-button-neutral/90", |
There was a problem hiding this comment.
Keep neutral-button overrides readable
When variant="neutral" is used, this class now renders the pill with bg-button-neutral, which the same change set maps to #1A1A1A. Any caller that still pins its child to the text color now becomes unreadable in the neutral state; for example SessionEditForm keeps Text className="text-text" on its neutral remove button (src/features/learning-plans/learning-plan-ui.tsx:333), and the completed-entry button uses a #1A1A1A check icon (src/app/entry/[id].tsx:290). Please either let those children inherit button-neutral-foreground or update their explicit colors when neutral is black.
Useful? React with 👍 / 👎.
Summary
hausaufgabesubtle color token and wire it through Tailwind configTesting