Skip to content

Align design system badge subtleties with Figma - #145

Merged
Gamius00 merged 3 commits into
release-v-1.0.3from
codex/fix-design-system-colours
Jun 25, 2026
Merged

Align design system badge subtleties with Figma#145
Gamius00 merged 3 commits into
release-v-1.0.3from
codex/fix-design-system-colours

Conversation

@FleetAdmiralJakob

Copy link
Copy Markdown
Collaborator

Summary

  • Update design-system docs and tokens to match Figma badge subtle fills exactly
  • Add the hausaufgabe subtle color token and wire it through Tailwind config
  • Refresh the shared design-system color constants to keep UI surfaces consistent

Testing

  • Not run (not requested)

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0e3c1774-8cfe-45b7-abdc-3302d42c7862

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-design-system-colours

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d74bbbf937

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

),
neutral: cn(
"bg-button-neutral shadow-black/5 active:bg-button-neutral/90",
"border-border border-hairline bg-button-neutral shadow-black/5 active:bg-button-neutral/90",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep neutral-button overrides readable

When variant="neutral" is used, this class now renders the pill with bg-button-neutral, which the same change set maps to #1A1A1A. Any caller that still pins its child to the text color now becomes unreadable in the neutral state; for example SessionEditForm keeps Text className="text-text" on its neutral remove button (src/features/learning-plans/learning-plan-ui.tsx:333), and the completed-entry button uses a #1A1A1A check icon (src/app/entry/[id].tsx:290). Please either let those children inherit button-neutral-foreground or update their explicit colors when neutral is black.

Useful? React with 👍 / 👎.

@FleetAdmiralJakob
FleetAdmiralJakob changed the base branch from main to release-v-1.0.3 June 24, 2026 13:38
@Gamius00
Gamius00 merged commit ae47dff into release-v-1.0.3 Jun 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants