[codex] Remove duplicate warning colour token

[FleetAdmiralJakob]

Summary

• Removed the duplicated warning/warningSubtle colour tokens from the design-system constants, Tailwind palette, and global CSS variables.
• Updated the newly shared WarningBanner component to use the existing info colour token for advisory banner styling.
• Kept the new PlanningHintBanner/shared-banner system from PR Extract reusable warning banner and link planning hints #140 intact, so learning-plan hints and notification guidance now pick up the semantic colour change from one place.
• Updated the design-system context docs so #FF9500 is documented only as the wrong status colour.

Why

The warning token duplicated the wrong colour values, which made the design system carry two names for the same visual role. After PR #140 introduced a reusable warning banner system, the right integration point is the shared banner component rather than the individual screens.

Impact

• Design tokens now have one canonical orange status colour: wrong.
• Advisory banners rendered through the shared banner system now use the yellow info colour instead of the orange wrong duplicate.
• Tailwind no longer exposes warning classes, so new UI should choose the more specific info, wrong, or destructive token.
• The PR is rebased onto the current release-v-1.0.3 branch so it works with the reusable warning-link changes from PR Extract reusable warning banner and link planning hints #140.

Validation

• env PATH="/Users/jakobroessner/.local/share/fnm/node-versions/v22.23.1/installation/bin:$PATH" node_modules/.bin/tsc --noEmit
• env PATH="/Users/jakobroessner/.local/share/fnm/node-versions/v22.23.1/installation/bin:$PATH" node_modules/.bin/biome lint .
• env PATH="/Users/jakobroessner/.local/share/fnm/node-versions/v22.23.1/installation/bin:$PATH" node_modules/.bin/eslint src convex index.ts

Note: pnpm typecheck could not run through the current shell because the active global runtime is Node 24 with pnpm 11, while the repo expects Node >=22 <24 and pnpm 10. The checks above were run directly against the installed repo dependencies using local Node 22.23.1.

Base branch

This PR targets release-v-1.0.3 because the cleanup belongs on the release branch where the design-system and reusable warning-banner work has landed.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0099ae83-b16b-4731-b60c-0cfa7dc6882f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/remove-warning-colour

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}