-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<> card search: extend to Rush Duel #341
Comments
kevinlul
added a commit
that referenced
this issue
Oct 8, 2023
This was referenced Apr 12, 2024
kevinlul
added a commit
that referenced
this issue
May 25, 2024
…arch Based on prior work 850ae19, 0311288 This will take longer to process due to checking for "r" before and after, and using immutables to identify duplicates The only difference in behaviour is that a duplicate with a Rush flag is no longer treated as a duplicate e.g. <code> r<code> only counted as one summon for "code" before and now counts as two distinct summons #341
kevinlul
added a commit
that referenced
this issue
May 25, 2024
kevinlul
added a commit
that referenced
this issue
May 26, 2024
7 tasks
kevinlul
added a commit
that referenced
this issue
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
<> card search should support Rush Duel cards in addition to OCG/TCG cards. Unlike old Bastion, this will be achieved with prefix and postfix operators. This avoids name collisions (e.g. Blue-Eyes White Dragon exists in both) as well as unwanted hits in the separate card pool (e.g. fuzzy search retrieving a Rush Duel card instead of an OCG card). Furthermore, depending on the choice of operator, this system is extensible to other card pools, such as Speed Duel skills.
r<>
,R<>
,<>r
, and<>R
will be the syntax for searching Rush Duel cards. This should produce an embed, as/rush-duel search
, while supporting all the same syntax as regular<>
search, such as Konami ID matching with%
and language mapping.{}
search in the old bot (mobile view) should attach an informational message to all Rush Duel hits directing users to use the new search syntax.Implementation
bastion-bot/src/events/message-search.ts
Lines 94 to 105 in adb604f
parseSummons
to find the character immediately before and after the summon. Before:[match.input[match.index - 1]
. After:match.input[match.index + e[0].length]]
. These are added to the return array and changespreprocess
's signature accordingly.bastion-bot/src/events/message-search.ts
Lines 277 to 278 in adb604f
The
inputToGetCardArguments
->getCard
approach needs to be updated to support multiple implementations of search. The follow-up formatting needs to be aware as wellbastion-bot/src/events/message-search.ts
Line 295 in adb604f
Current Rush Duel equivalents:
bastion-bot/src/commands/rush-duel.ts
Lines 238 to 244 in adb604f
bastion-bot/src/commands/rush-duel.ts
Line 48 in adb604f
Metrics reporting should be updated to account for multiple search types. Unit testing on the message search module should be vastly expanded to cover the range of inputs.
The text was updated successfully, but these errors were encountered: