Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performance tuning #652

Merged
merged 19 commits into from
Dec 12, 2021
Merged

performance tuning #652

merged 19 commits into from
Dec 12, 2021

Conversation

DaveSkender
Copy link
Owner

@DaveSkender DaveSkender commented Dec 5, 2021

General performance tuning and test data updates. Highlights:

  • add extreme size test data + add more scenarios to bad data
  • opportunistically and carefully replace decimal with double for non-monetary calculations to improve performance - see Precisions v. Performance of `decimal` vs `double` #649
  • there may be opportunities to do more conversions to double, later

Breaking changes

Many indicators have had either input parameters or output results class properties changed from decimal to double, too many to enumerate here. See documentation for current types. Summary of changes: mods.xlsx

Checklist

  • My code follows the existing style, code structure, and naming taxonomy
  • I have commented my code, particularly in hard-to-understand areas
  • I have performed a self-review of my own code and included any verifying manual calculations
  • I have added or updated unit tests that prove my fix is effective or that my feature works, and achieves sufficient code coverage. New and existing unit tests pass locally and in the build (below) with my changes
  • My changes generate no new warnings and running code analysis does not produce any issues
  • I have added or run the performance tests that depict optimal execution times
  • I have made corresponding changes to the documentation

@DaveSkender DaveSkender added the breaking change Change that modifies a previously released API profile label Dec 7, 2021
@DaveSkender DaveSkender marked this pull request as ready for review December 12, 2021 03:13
@DaveSkender DaveSkender merged commit 485a077 into main Dec 12, 2021
@DaveSkender DaveSkender deleted the refactor-performance branch December 12, 2021 05:07
@github-actions
Copy link

This Pull Request has been automatically locked since there has not been any recent activity after it was closed. Please open a new Issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking change Change that modifies a previously released API profile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant