Skip to content

Conversation

@y9v
Copy link
Member

@y9v y9v commented Oct 24, 2025

Motivation

We are adding http.endpoint tag in the ruby tracer:
DataDog/dd-trace-rb#4995

APPSEC-58489

Changes

This PR enables resource renaming tests for Ruby. Tests for stats aggregations related to resource renaming are disabled, since we don't have trace stats in Ruby library yet.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@y9v y9v self-assigned this Oct 24, 2025
@github-actions
Copy link
Contributor

CODEOWNERS have been resolved as:

manifests/ruby.yml                                                      @DataDog/ruby-guild @DataDog/asm-ruby
utils/build/docker/ruby/rack/config.ru                                  @DataDog/ruby-guild @DataDog/asm-ruby @DataDog/system-tests-core
utils/build/docker/ruby/rails42/config/routes.rb                        @DataDog/ruby-guild @DataDog/asm-ruby @DataDog/system-tests-core
utils/build/docker/ruby/rails52/config/routes.rb                        @DataDog/ruby-guild @DataDog/asm-ruby @DataDog/system-tests-core
utils/build/docker/ruby/rails61/config/routes.rb                        @DataDog/ruby-guild @DataDog/asm-ruby @DataDog/system-tests-core
utils/build/docker/ruby/rails72/config/routes.rb                        @DataDog/ruby-guild @DataDog/asm-ruby @DataDog/system-tests-core
utils/build/docker/ruby/rails80/config/routes.rb                        @DataDog/ruby-guild @DataDog/asm-ruby @DataDog/system-tests-core

@y9v y9v force-pushed the ruby-enable-resource-renaming-tests branch 2 times, most recently from 62a2fc6 to ccb87ad Compare October 24, 2025 15:25
@y9v y9v changed the title [ruby@add-http-endpoint-tag-when-route-is-missing] Enable resource renaming tests [Ruby] Enable resource renaming tests Oct 28, 2025
@y9v y9v force-pushed the ruby-enable-resource-renaming-tests branch from ccb87ad to 3c73bca Compare October 28, 2025 16:05
@y9v y9v marked this pull request as ready for review October 29, 2025 07:55
@y9v y9v requested review from a team as code owners October 29, 2025 07:55
@y9v y9v merged commit c047924 into main Oct 29, 2025
379 checks passed
@y9v y9v deleted the ruby-enable-resource-renaming-tests branch October 29, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants