-
Notifications
You must be signed in to change notification settings - Fork 398
Add http.endpoint tag
#4995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add http.endpoint tag
#4995
Conversation
Typing analysisIgnored filesThis PR introduces 1 ignored file. It decreases the percentage of typed files from 35.91% to 35.87% (-0.04%). Ignored files (+1-0)❌ Introduced: |
BenchmarksBenchmark execution time: 2025-10-27 14:05:57 Comparing candidate commit d43e6b4 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 2 unstable metrics. |
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: 394e169 | Docs | Was this helpful? Give us feedback! |
http.endpoint tag
688200d to
59ee60b
Compare
We only infer http.endpoint tag from the path for nested rack applications that are not instrumented.
478029d to
761ce85
Compare
Strech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I think there are some discrepancy between code and typespec. I've left few suggestions for route inferring, but nothing blocking. Well done!
vpellan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (Comments are non-blockers)
What does this PR do?
This PR adds
http.endpointtag for requests for all rack applications (nested and standalone).Motivation:
We want to be able to infer routes for rack applications for which we can't get the exact route. This new
http.endpointtag will usehttp.routetag value whenever it is available, and will infer the route from the request path when the route is not available.Change log entry
Yes. Tracing: Add
http.endpointtag which contains the route whenever the routing information is available, and falls back to route inferred from the request path.Additional Notes:
APPSEC-58489
How to test the change?
CI and manual testing