Remove ResourceAttributesAsTags #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
mackjmr
added a commit
to mackjmr/opentelemetry-collector-contrib
that referenced
this pull request
Dec 12, 2023
Removes call to `metrics.WithResourceAttributesAsTags()` which is a no-op. This option is picked up here: https://github.com/DataDog/datadog-agent/blob/main/comp/otelcol/otlp/internal/serializerexporter/factory.go#L60. This option will been removed from `pkg/otlp/metrics` in this PR: DataDog/opentelemetry-mapping-go#219 This was flagged here: open-telemetry#29702
mx-psi
approved these changes
Dec 12, 2023
mx-psi
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Dec 12, 2023
**Description:** Removes call to `metrics.WithResourceAttributesAsTags()` which is a no-op. This option is picked up here: https://github.com/DataDog/datadog-agent/blob/main/comp/otelcol/otlp/internal/serializerexporter/factory.go#L60. This option will been removed from `pkg/otlp/metrics` in this PR: DataDog/opentelemetry-mapping-go#219 **Link to tracking Issue:** Closes #29702 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.>
This was referenced Dec 12, 2023
mx-psi
added a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Dec 13, 2023
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Bump opentelemetry-mapping-go modules to v0.9.0. This includes: - DataDog/opentelemetry-mapping-go/pull/218 and DataDog/opentelemetry-mapping-go/pull/220 - DataDog/opentelemetry-mapping-go/pull/219 - DataDog/opentelemetry-mapping-go/pull/213 - DataDog/opentelemetry-mapping-go/pull/202
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jan 10, 2024
…9785) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Bump opentelemetry-mapping-go modules to v0.9.0. This includes: - DataDog/opentelemetry-mapping-go/pull/218 and DataDog/opentelemetry-mapping-go/pull/220 - DataDog/opentelemetry-mapping-go/pull/219 - DataDog/opentelemetry-mapping-go/pull/213 - DataDog/opentelemetry-mapping-go/pull/202
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove
ResourceAttributesAsTagsfrom translator config as this gets called directly via metrics exporter config in:Motivation
This was flagged in: open-telemetry/opentelemetry-collector-contrib#29702 and #156.