Remove mapping for process.runtime.jvm.gc.duration
#213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mackjmr
reviewed
Dec 6, 2023
| newCountWithHost(newDims("jvm.gc.parnew.time.sum"), uint64(seconds(startTs+1)), 0, fallbackHostname), | ||
| newGaugeWithHost(newDims("jvm.gc.parnew.time.min"), uint64(seconds(startTs+1)), -100, fallbackHostname), | ||
| newGaugeWithHost(newDims("jvm.gc.parnew.time.max"), uint64(seconds(startTs+1)), 100, fallbackHostname), | ||
| newCountWithHost(newDims("process.runtime.jvm.threads.count.count"), uint64(seconds(startTs+1)), 100, fallbackHostname), |
There was a problem hiding this comment.
Seems like we are removing the mapping from process.runtime.jvm.gc.duration to jvm.gc.parnew.time, not sure how metric process.runtime.jvm.threads.count.count fit in to this change ?
There was a problem hiding this comment.
Or are you just adding more test cases which are unrelated ? If this is the case then LGTM, just want to make sure I'm not missing something :)
There was a problem hiding this comment.
Yeah just adding more test cases that are unrelated, this test was failing since we removed the mapping so I changed it to a different mapping name to keep the same test for histograms.
mackjmr
approved these changes
Dec 7, 2023
This was referenced Dec 12, 2023
mx-psi
added a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Dec 13, 2023
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Bump opentelemetry-mapping-go modules to v0.9.0. This includes: - DataDog/opentelemetry-mapping-go/pull/218 and DataDog/opentelemetry-mapping-go/pull/220 - DataDog/opentelemetry-mapping-go/pull/219 - DataDog/opentelemetry-mapping-go/pull/213 - DataDog/opentelemetry-mapping-go/pull/202
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jan 10, 2024
…9785) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Bump opentelemetry-mapping-go modules to v0.9.0. This includes: - DataDog/opentelemetry-mapping-go/pull/218 and DataDog/opentelemetry-mapping-go/pull/220 - DataDog/opentelemetry-mapping-go/pull/219 - DataDog/opentelemetry-mapping-go/pull/213 - DataDog/opentelemetry-mapping-go/pull/202
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes runtime metric mapping for
process.runtime.jvm.gc.duration->jvm.gc.parnew.time.Motivation
This mapping was causing problems due to the distribution overshadowing behavior in the backend. This is because
process.runtime.jvm.gc.durationis an OTel histogram which gets converted to a DD distribution under the name ofjvm.gc.parnew.time. This results in olderjvm.gc.parnew.timevalues getting overridden because they're of type gauge.