Skip to content
This repository was archived by the owner on Sep 25, 2024. It is now read-only.

Change symbol reporter interface to allow opening any file#2

Merged
nsavoire merged 1 commit into
datadogfrom
nsavoire/change_symbol_reporter_interface
Sep 19, 2024
Merged

Change symbol reporter interface to allow opening any file#2
nsavoire merged 1 commit into
datadogfrom
nsavoire/change_symbol_reporter_interface

Conversation

@nsavoire
Copy link
Copy Markdown
Collaborator

@nsavoire nsavoire commented Sep 6, 2024

When uploading elf symbols, it is sometimes necessary to open a file other than the reported executable (eg. to look for separate debug information).

@nsavoire nsavoire force-pushed the nsavoire/change_symbol_reporter_interface branch from 7816aa5 to 3b56fbb Compare September 6, 2024 15:04
@Gandem Gandem self-requested a review September 6, 2024 17:53
@nsavoire nsavoire changed the base branch from main to datadog September 11, 2024 10:18
When uploading elf symbols, it is sometimes necessary to open a file
other than the reported executalle (eg. to look for separate debug
information).
@nsavoire nsavoire force-pushed the nsavoire/change_symbol_reporter_interface branch from 3b56fbb to c5e338f Compare September 11, 2024 10:28
@nsavoire nsavoire requested review from a team and r1viollet September 11, 2024 11:38
Copy link
Copy Markdown

@r1viollet r1viollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@Gandem Gandem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nsavoire nsavoire merged commit 47a86fe into datadog Sep 19, 2024
@nsavoire nsavoire deleted the nsavoire/change_symbol_reporter_interface branch September 19, 2024 13:08
nsavoire added a commit that referenced this pull request Sep 19, 2024
When uploading elf symbols, it is sometimes necessary to open a file
other than the reported executalle (eg. to look for separate debug
information).
nsavoire added a commit that referenced this pull request Sep 20, 2024
When uploading elf symbols, it is sometimes necessary to open a file
other than the reported executalle (eg. to look for separate debug
information).
nsavoire added a commit that referenced this pull request Sep 23, 2024
When uploading elf symbols, it is sometimes necessary to open a file
other than the reported executalle (eg. to look for separate debug
information).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants