Add ELF symbol upload#3
Merged
Merged
Conversation
nsavoire
force-pushed
the
nsavoire/symbol_upload
branch
from
ecd0264 to
4fe01fb
Compare
nsavoire
force-pushed
the
nsavoire/symbol_upload
branch
from
4fe01fb to
d40603c
Compare
r1viollet
approved these changes
Sep 11, 2024
Collaborator
r1viollet
left a comment
r1viollet
left a comment
There was a problem hiding this comment.
LGTM
Thanks for the port.
Gandem
reviewed
Sep 18, 2024
Member
Gandem
left a comment
Gandem
left a comment
There was a problem hiding this comment.
Made a first pass, will continue reviewing in a few 🙇
Gandem
reviewed
Sep 18, 2024
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
nsavoire
force-pushed
the
nsavoire/symbol_upload
branch
from
40fd52f to
1a65e49
Compare
Gandem
reviewed
Sep 19, 2024
| ) | ||
|
|
||
| const uploadCacheSize = 16384 | ||
| const uploadQueueSize = 1000 |
Member
There was a problem hiding this comment.
I checked one of the most loaded relenv nodes, and on startup we seeing around 200 symbols uploaded, so the order of magnitude for the upload queue size LGTM 👍
Co-authored-by: Nayef Ghattas <nayef.ghattas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on DataDog/opentelemetry-ebpf-profiler#2