Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Connection Pool metrics #16673

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Add support for Connection Pool metrics #16673

merged 1 commit into from
Jan 25, 2024
+4,850 −3

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Jan 22, 2024 •
edited
Loading

What does this PR do?

Add support for Connection Pool metrics.

Motivation

  • Customer request

Additional Notes

  • Getting this MBean requires us to have a connection pool and established connections, that's why I had to add a database and create the DataSource. It makes the tests a bit slower so I only added it to the standalone tests
  • https://datadoghq.atlassian.net/browse/AI-3732

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

@ghost ghost added the integration/tomcat label Jan 22, 2024
@FlorentClarret FlorentClarret force-pushed the florentclarret/tomcat/jdbc branch from 229a0be to fad13f5 Compare January 22, 2024 06:41
@FlorentClarret FlorentClarret marked this pull request as ready for review January 22, 2024 06:43
@FlorentClarret FlorentClarret requested a review from a team as a code owner January 22, 2024 06:43
@FlorentClarret FlorentClarret added this to the 7.52.0 milestone Jan 22, 2024
@github-actions GitHub Actions
Copy link

Test Results

12 files  12 suites   59s ⏱️
 2 tests  2 ✅  0 💤 0 ❌
24 runs  12 ✅ 12 💤 0 ❌

Results for commit fad13f5.

@FlorentClarret FlorentClarret merged commit ab0011d into master Jan 25, 2024
36 checks passed
@FlorentClarret FlorentClarret deleted the florentclarret/tomcat/jdbc branch January 25, 2024 14:09
@mcculls mcculls mentioned this pull request Mar 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kyle-Neale Kyle-Neale Kyle-Neale approved these changes

Assignees
No one assigned
Labels
integration/tomcat team/agent-integrations
Projects
None yet
Milestone
7.52.0
Development

Successfully merging this pull request may close these issues.
2 participants
@FlorentClarret @Kyle-Neale