Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump JMXFetch integrations-core submodule to 7.52.0 #6852

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Bump JMXFetch integrations-core submodule to 7.52.0 #6852

merged 1 commit into from
Mar 28, 2024

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Mar 27, 2024

@mcculls mcculls added the tag: dependencies Dependencies related changes label Mar 27, 2024
@mcculls mcculls requested a review from a team as a code owner March 27, 2024 13:28
@mcculls mcculls requested review from dougqh and nayeem-kamal March 27, 2024 13:28
@github-actions GitHub Actions
Copy link
Contributor

Hi! 👋 Looks like you updated a Git Submodule.
If this was not intentional please make sure to:

@mcculls mcculls added comp: metrics Metrics and removed tag: dependencies Dependencies related changes labels Mar 27, 2024
@pr-commenter
Copy link

pr-commenter bot commented Mar 27, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/jmxfetch-integrations-core-7.52.0
git_commit_date 1711544983 1711545884
git_commit_sha 5a80fb6 be94fcf
release_version 1.32.0-SNAPSHOT~5a80fb6c0b 1.32.0-SNAPSHOT~be94fcf6ae
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1711549396 1711549396
ci_job_id 470767685 470767685
ci_pipeline_id 30915223 30915223
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.32.0-SNAPSHOT~be94fcf6ae, baseline=1.32.0-SNAPSHOT~5a80fb6c0b

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.072 s) : 0, 1071793
Total [baseline] (10.384 s) : 0, 10383567
Agent [candidate] (1.075 s) : 0, 1074667
Total [candidate] (10.389 s) : 0, 10388573
section appsec
Agent [baseline] (1.19 s) : 0, 1190115
Total [baseline] (10.459 s) : 0, 10459374
Agent [candidate] (1.203 s) : 0, 1203250
Total [candidate] (10.683 s) : 0, 10683389
section iast
Agent [baseline] (1.202 s) : 0, 1202399
Total [baseline] (10.821 s) : 0, 10821428
Agent [candidate] (1.194 s) : 0, 1193879
Total [candidate] (10.833 s) : 0, 10832704
section profiling
Agent [baseline] (1.272 s) : 0, 1272470
Total [baseline] (10.683 s) : 0, 10682882
Agent [candidate] (1.268 s) : 0, 1268312
Total [candidate] (10.641 s) : 0, 10640664
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.072 s -
Agent appsec 1.19 s 118.322 ms (11.0%)
Agent iast 1.202 s 130.606 ms (12.2%)
Agent profiling 1.272 s 200.677 ms (18.7%)
Total tracing 10.384 s -
Total appsec 10.459 s 75.808 ms (0.7%)
Total iast 10.821 s 437.862 ms (4.2%)
Total profiling 10.683 s 299.315 ms (2.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.075 s -
Agent appsec 1.203 s 128.583 ms (12.0%)
Agent iast 1.194 s 119.211 ms (11.1%)
Agent profiling 1.268 s 193.645 ms (18.0%)
Total tracing 10.389 s -
Total appsec 10.683 s 294.817 ms (2.8%)
Total iast 10.833 s 444.132 ms (4.3%)
Total profiling 10.641 s 252.092 ms (2.4%) 
gantt
    title petclinic - break down per module: candidate=1.32.0-SNAPSHOT~be94fcf6ae, baseline=1.32.0-SNAPSHOT~5a80fb6c0b

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.624 ms) : 0, 683624
BytebuddyAgent [candidate] (685.404 ms) : 0, 685404
GlobalTracer [baseline] (296.031 ms) : 0, 296031
GlobalTracer [candidate] (297.463 ms) : 0, 297463
AppSec [baseline] (49.306 ms) : 0, 49306
AppSec [candidate] (48.972 ms) : 0, 48972
Remote Config [baseline] (1.052 ms) : 0, 1052
Remote Config [candidate] (1.083 ms) : 0, 1083
Telemetry [baseline] (7.433 ms) : 0, 7433
Telemetry [candidate] (7.421 ms) : 0, 7421
section appsec
BytebuddyAgent [baseline] (691.26 ms) : 0, 691260
BytebuddyAgent [candidate] (699.514 ms) : 0, 699514
GlobalTracer [baseline] (289.536 ms) : 0, 289536
GlobalTracer [candidate] (293.55 ms) : 0, 293550
AppSec [baseline] (149.133 ms) : 0, 149133
AppSec [candidate] (149.414 ms) : 0, 149414
IAST [baseline] (18.646 ms) : 0, 18646
IAST [candidate] (18.788 ms) : 0, 18788
Remote Config [baseline] (596.207 µs) : 0, 596
Remote Config [candidate] (609.383 µs) : 0, 609
Telemetry [baseline] (6.738 ms) : 0, 6738
Telemetry [candidate] (6.825 ms) : 0, 6825
section iast
BytebuddyAgent [baseline] (797.953 ms) : 0, 797953
BytebuddyAgent [candidate] (791.316 ms) : 0, 791316
GlobalTracer [baseline] (288.871 ms) : 0, 288871
GlobalTracer [candidate] (288.005 ms) : 0, 288005
AppSec [baseline] (48.857 ms) : 0, 48857
AppSec [candidate] (51.104 ms) : 0, 51104
IAST [baseline] (24.97 ms) : 0, 24970
IAST [candidate] (21.784 ms) : 0, 21784
Remote Config [baseline] (583.413 µs) : 0, 583
Remote Config [candidate] (740.463 µs) : 0, 740
Telemetry [baseline] (6.636 ms) : 0, 6636
Telemetry [candidate] (6.587 ms) : 0, 6587
section profiling
BytebuddyAgent [baseline] (680.282 ms) : 0, 680282
BytebuddyAgent [candidate] (677.116 ms) : 0, 677116
GlobalTracer [baseline] (381.406 ms) : 0, 381406
GlobalTracer [candidate] (381.151 ms) : 0, 381151
AppSec [baseline] (50.107 ms) : 0, 50107
AppSec [candidate] (50.034 ms) : 0, 50034
Remote Config [baseline] (867.345 µs) : 0, 867
Remote Config [candidate] (877.177 µs) : 0, 877
Telemetry [baseline] (7.485 ms) : 0, 7485
Telemetry [candidate] (7.403 ms) : 0, 7403
ProfilingAgent [baseline] (95.938 ms) : 0, 95938
ProfilingAgent [candidate] (95.433 ms) : 0, 95433
Profiling [baseline] (95.962 ms) : 0, 95962
Profiling [candidate] (95.457 ms) : 0, 95457
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.32.0-SNAPSHOT~be94fcf6ae, baseline=1.32.0-SNAPSHOT~5a80fb6c0b

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.077 s) : 0, 1077101
Total [baseline] (8.551 s) : 0, 8550923
Agent [candidate] (1.074 s) : 0, 1073822
Total [candidate] (8.553 s) : 0, 8552740
section iast
Agent [baseline] (1.197 s) : 0, 1196605
Total [baseline] (9.089 s) : 0, 9089408
Agent [candidate] (1.197 s) : 0, 1197201
Total [candidate] (9.079 s) : 0, 9078590
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.195 s) : 0, 1194689
Total [baseline] (9.029 s) : 0, 9029213
Agent [candidate] (1.199 s) : 0, 1198586
Total [candidate] (9.126 s) : 0, 9126098
section iast_TELEMETRY_OFF
Agent [baseline] (1.19 s) : 0, 1190051
Total [baseline] (9.034 s) : 0, 9034408
Agent [candidate] (1.196 s) : 0, 1195774
Total [candidate] (9.082 s) : 0, 9081814
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.077 s -
Agent iast 1.197 s 119.503 ms (11.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.195 s 117.588 ms (10.9%)
Agent iast_TELEMETRY_OFF 1.19 s 112.95 ms (10.5%)
Total tracing 8.551 s -
Total iast 9.089 s 538.485 ms (6.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.029 s 478.29 ms (5.6%)
Total iast_TELEMETRY_OFF 9.034 s 483.485 ms (5.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.074 s -
Agent iast 1.197 s 123.378 ms (11.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.199 s 124.763 ms (11.6%)
Agent iast_TELEMETRY_OFF 1.196 s 121.951 ms (11.4%)
Total tracing 8.553 s -
Total iast 9.079 s 525.85 ms (6.1%)
Total iast_HARDCODED_SECRET_DISABLED 9.126 s 573.358 ms (6.7%)
Total iast_TELEMETRY_OFF 9.082 s 529.074 ms (6.2%) 
gantt
    title insecure-bank - break down per module: candidate=1.32.0-SNAPSHOT~be94fcf6ae, baseline=1.32.0-SNAPSHOT~5a80fb6c0b

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.356 ms) : 0, 687356
BytebuddyAgent [candidate] (685.053 ms) : 0, 685053
GlobalTracer [baseline] (297.238 ms) : 0, 297238
GlobalTracer [candidate] (296.943 ms) : 0, 296943
AppSec [baseline] (49.403 ms) : 0, 49403
AppSec [candidate] (48.915 ms) : 0, 48915
Remote Config [baseline] (1.085 ms) : 0, 1085
Remote Config [candidate] (1.08 ms) : 0, 1080
Telemetry [baseline] (7.513 ms) : 0, 7513
Telemetry [candidate] (7.507 ms) : 0, 7507
section iast
BytebuddyAgent [baseline] (793.639 ms) : 0, 793639
BytebuddyAgent [candidate] (792.482 ms) : 0, 792482
GlobalTracer [baseline] (287.667 ms) : 0, 287667
GlobalTracer [candidate] (288.299 ms) : 0, 288299
AppSec [baseline] (50.273 ms) : 0, 50273
AppSec [candidate] (48.93 ms) : 0, 48930
IAST [baseline] (22.69 ms) : 0, 22690
IAST [candidate] (25.158 ms) : 0, 25158
Remote Config [baseline] (583.642 µs) : 0, 584
Remote Config [candidate] (596.334 µs) : 0, 596
Telemetry [baseline] (7.429 ms) : 0, 7429
Telemetry [candidate] (7.4 ms) : 0, 7400
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (791.345 ms) : 0, 791345
BytebuddyAgent [candidate] (793.678 ms) : 0, 793678
GlobalTracer [baseline] (287.261 ms) : 0, 287261
GlobalTracer [candidate] (288.639 ms) : 0, 288639
AppSec [baseline] (49.604 ms) : 0, 49604
AppSec [candidate] (48.177 ms) : 0, 48177
IAST [baseline] (24.231 ms) : 0, 24231
IAST [candidate] (25.774 ms) : 0, 25774
Remote Config [baseline] (569.961 µs) : 0, 570
Remote Config [candidate] (586.357 µs) : 0, 586
Telemetry [baseline] (7.422 ms) : 0, 7422
Telemetry [candidate] (7.371 ms) : 0, 7371
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (787.796 ms) : 0, 787796
BytebuddyAgent [candidate] (790.92 ms) : 0, 790920
GlobalTracer [baseline] (287.22 ms) : 0, 287220
GlobalTracer [candidate] (289.411 ms) : 0, 289411
AppSec [baseline] (49.914 ms) : 0, 49914
AppSec [candidate] (49.201 ms) : 0, 49201
IAST [baseline] (23.785 ms) : 0, 23785
IAST [candidate] (24.754 ms) : 0, 24754
Remote Config [baseline] (565.609 µs) : 0, 566
Remote Config [candidate] (565.178 µs) : 0, 565
Telemetry [baseline] (6.495 ms) : 0, 6495
Telemetry [candidate] (6.567 ms) : 0, 6567
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-03-27T13:55:28 2024-03-27T14:17:31
git_branch master mcculls/jmxfetch-integrations-core-7.52.0
git_commit_date 1711544983 1711545884
git_commit_sha 5a80fb6 be94fcf
release_version 1.32.0-SNAPSHOT~5a80fb6c0b 1.32.0-SNAPSHOT~be94fcf6ae
start_time 2024-03-27T13:55:15 2024-03-27T14:17:18
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1711549396 1711549396
ci_job_id 470767685 470767685
ci_pipeline_id 30915223 30915223
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.32.0-SNAPSHOT~be94fcf6ae, baseline=1.32.0-SNAPSHOT~5a80fb6c0b
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.325 ms) : 1305, 1345
.   : milestone, 1325,
appsec (1.713 ms) : 1688, 1737
.   : milestone, 1713,
appsec_no_iast (1.702 ms) : 1676, 1727
.   : milestone, 1702,
iast (1.49 ms) : 1467, 1513
.   : milestone, 1490,
profiling (1.512 ms) : 1486, 1537
.   : milestone, 1512,
tracing (1.467 ms) : 1444, 1490
.   : milestone, 1467,
section candidate
no_agent (1.35 ms) : 1330, 1370
.   : milestone, 1350,
appsec (1.709 ms) : 1683, 1735
.   : milestone, 1709,
appsec_no_iast (1.735 ms) : 1711, 1759
.   : milestone, 1735,
iast (1.478 ms) : 1455, 1501
.   : milestone, 1478,
profiling (1.496 ms) : 1470, 1521
.   : milestone, 1496,
tracing (1.497 ms) : 1472, 1521
.   : milestone, 1497,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.325 ms [1.305 ms, 1.345 ms] -
appsec 1.713 ms [1.688 ms, 1.737 ms] 387.609 µs (29.3%)
appsec_no_iast 1.702 ms [1.676 ms, 1.727 ms] 376.766 µs (28.4%)
iast 1.49 ms [1.467 ms, 1.513 ms] 164.94 µs (12.4%)
profiling 1.512 ms [1.486 ms, 1.537 ms] 186.579 µs (14.1%)
tracing 1.467 ms [1.444 ms, 1.49 ms] 141.964 µs (10.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.35 ms [1.33 ms, 1.37 ms] -
appsec 1.709 ms [1.683 ms, 1.735 ms] 358.211 µs (26.5%)
appsec_no_iast 1.735 ms [1.711 ms, 1.759 ms] 384.587 µs (28.5%)
iast 1.478 ms [1.455 ms, 1.501 ms] 127.741 µs (9.5%)
profiling 1.496 ms [1.47 ms, 1.521 ms] 145.179 µs (10.8%)
tracing 1.497 ms [1.472 ms, 1.521 ms] 146.268 µs (10.8%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.32.0-SNAPSHOT~be94fcf6ae, baseline=1.32.0-SNAPSHOT~5a80fb6c0b
    dateFormat X
    axisFormat %s
section baseline
no_agent (365.299 µs) : 346, 385
.   : milestone, 365,
iast (468.662 µs) : 448, 489
.   : milestone, 469,
iast_FULL (536.657 µs) : 516, 557
.   : milestone, 537,
iast_GLOBAL (502.264 µs) : 481, 524
.   : milestone, 502,
iast_HARDCODED_SECRET_DISABLED (477.992 µs) : 457, 499
.   : milestone, 478,
iast_INACTIVE (446.502 µs) : 426, 467
.   : milestone, 447,
iast_TELEMETRY_OFF (465.714 µs) : 445, 486
.   : milestone, 466,
tracing (445.092 µs) : 424, 466
.   : milestone, 445,
section candidate
no_agent (363.783 µs) : 343, 384
.   : milestone, 364,
iast (472.102 µs) : 451, 493
.   : milestone, 472,
iast_FULL (537.01 µs) : 517, 558
.   : milestone, 537,
iast_GLOBAL (501.721 µs) : 479, 524
.   : milestone, 502,
iast_HARDCODED_SECRET_DISABLED (471.996 µs) : 451, 493
.   : milestone, 472,
iast_INACTIVE (449.862 µs) : 429, 471
.   : milestone, 450,
iast_TELEMETRY_OFF (463.088 µs) : 442, 484
.   : milestone, 463,
tracing (444.277 µs) : 423, 465
.   : milestone, 444,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 365.299 µs [345.657 µs, 384.942 µs] -
iast 468.662 µs [448.462 µs, 488.861 µs] 103.362 µs (28.3%)
iast_FULL 536.657 µs [516.267 µs, 557.047 µs] 171.358 µs (46.9%)
iast_GLOBAL 502.264 µs [480.661 µs, 523.868 µs] 136.965 µs (37.5%)
iast_HARDCODED_SECRET_DISABLED 477.992 µs [456.742 µs, 499.241 µs] 112.693 µs (30.8%)
iast_INACTIVE 446.502 µs [425.623 µs, 467.382 µs] 81.203 µs (22.2%)
iast_TELEMETRY_OFF 465.714 µs [445.066 µs, 486.363 µs] 100.415 µs (27.5%)
tracing 445.092 µs [423.694 µs, 466.49 µs] 79.793 µs (21.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 363.783 µs [343.456 µs, 384.11 µs] -
iast 472.102 µs [451.409 µs, 492.795 µs] 108.319 µs (29.8%)
iast_FULL 537.01 µs [516.5 µs, 557.52 µs] 173.227 µs (47.6%)
iast_GLOBAL 501.721 µs [479.329 µs, 524.113 µs] 137.938 µs (37.9%)
iast_HARDCODED_SECRET_DISABLED 471.996 µs [451.014 µs, 492.979 µs] 108.213 µs (29.7%)
iast_INACTIVE 449.862 µs [429.045 µs, 470.68 µs] 86.079 µs (23.7%)
iast_TELEMETRY_OFF 463.088 µs [442.338 µs, 483.837 µs] 99.305 µs (27.3%)
tracing 444.277 µs [423.313 µs, 465.241 µs] 80.494 µs (22.1%)

@mcculls mcculls merged commit 08d7b46 into master Mar 28, 2024
80 checks passed
@mcculls mcculls deleted the mcculls/jmxfetch-integrations-core-7.52.0 branch March 28, 2024 23:10
@github-actions github-actions bot added this to the 1.32.0 milestone Mar 28, 2024
@PerfectSlayer PerfectSlayer added the tag: dependencies Dependencies related changes label Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougqh dougqh dougqh approved these changes

@nayeem-kamal nayeem-kamal Awaiting requested review from nayeem-kamal nayeem-kamal is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: metrics Metrics tag: dependencies Dependencies related changes
Projects
None yet
Milestone
1.32.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mcculls @dougqh @PerfectSlayer