Skip to content

Conversation

@marcotc
Copy link
Member

@marcotc marcotc commented Dec 23, 2025

With system-tests builds downloading a large amount of Python packages, sometimes it suffers from transitory failures, like this recent one (from this PR).

This PR adds 3 retry attempts to building system tests (through the officially supported SYSTEM_TEST_BUILD_ATTEMPTS env var).

This number of retries is already used in other CI pipelines for system-tests builds.

Change log entry
No.

Additional Notes:

How to test the change?

@marcotc marcotc self-assigned this Dec 23, 2025
@marcotc marcotc added the dev/ci Involves CircleCI, GitHub Actions, or GitLab label Dec 23, 2025
@marcotc marcotc requested a review from a team as a code owner December 23, 2025 23:09
@marcotc marcotc added the dev/internal Other internal work that does not need to be included in the changelog label Dec 23, 2025
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Dec 23, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 100.00%
Overall Coverage: 95.25% (-0.00%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 1d4f47c | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Dec 23, 2025

Benchmarks

Benchmark execution time: 2025-12-24 17:49:20

Comparing candidate commit 1d4f47c in PR branch retry-sys-test with baseline commit 0b94b37 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 2 unstable metrics.

@p-datadog p-datadog merged commit 118ecca into master Dec 24, 2025
359 checks passed
@p-datadog p-datadog deleted the retry-sys-test branch December 24, 2025 18:09
@github-actions github-actions bot added this to the 2.24.0 milestone Dec 24, 2025
p-datadog pushed a commit that referenced this pull request Dec 29, 2025
* commit 'a4c17f9fb9a19946b4ae099ad894c4e50c68ce81': (25 commits)
  improve diagnostics of "leaked" file descriptors for jruby
  DEBUG-4548 Core: fix worker shutdown race  (#5176)
  Retry system-test build (#5181)
  Fix Baggage type check (#5182)
  [🤖] Update System Tests: https://github.com/DataDog/dd-trace-rb/actions/runs/20487829791 (#5183)
  [🤖] Update Latest Dependency: https://github.com/DataDog/dd-trace-rb/actions/runs/20401889084 (#5180)
  DEBUG-3499 DI: do not instrument when there is already an installed probe with the same id (#5169)
  DEBUG-3499 DI: rework RC interface (#5165)
  set DI test duration upper bound to 1000 seconds (#5161)
  add missing supported config default value
  [🤖] Update System Tests: https://github.com/DataDog/dd-trace-rb/actions/runs/20401907816 (#5179)
  Use better type definitions for OT baggage module (#5155)
  normalize headers
  new default for OTEL_EXPORTER_OTLP_METRICS_PROTOCOL
  clean up config docs
  remove protocol from exporter args
  do not hardcode env look up
  add test case and fix origin
  clean up get_metrics_config_with_fallback
  remove default value
  ...
p-datadog pushed a commit that referenced this pull request Jan 5, 2026
* master: (129 commits)
  Transports: remove api_version (#5164)
  DEBUG-4548 Telemetry: send events in forked children + telemetry metrics reset after fork (#5159)
  Ignore "leaked" pipe file descriptors in JRuby, improve diagnostics  (#5188)
  debug-4548 Increase number of iterations for flakiness (#5184)
  [🤖] Update System Tests: https://github.com/DataDog/dd-trace-rb/actions/runs/20684824141
  [🤖] Update System Tests: https://github.com/DataDog/dd-trace-rb/actions/runs/20616292456 (#5190)
  downgrade ffi for ruby 4.0 & 2.5 (#5189)
  Fix ruby warnings when accessing undefined instance variables (#5178)
  DEBUG-3499 DI: fix accounting when intrumenting upon class definition, add instr… (#5168)
  DEBUG-3499 RC: add diagnostics for invalid values (#5167)
  DEBUG-4548 Core: fix worker shutdown race  (#5176)
  Retry system-test build (#5181)
  Fix Baggage type check (#5182)
  [🤖] Update System Tests: https://github.com/DataDog/dd-trace-rb/actions/runs/20487829791 (#5183)
  [🤖] Update Latest Dependency: https://github.com/DataDog/dd-trace-rb/actions/runs/20401889084 (#5180)
  DEBUG-3499 DI: do not instrument when there is already an installed probe with the same id (#5169)
  DEBUG-3499 DI: rework RC interface (#5165)
  set DI test duration upper bound to 1000 seconds (#5161)
  add missing supported config default value
  [🤖] Update System Tests: https://github.com/DataDog/dd-trace-rb/actions/runs/20401907816 (#5179)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev/ci Involves CircleCI, GitHub Actions, or GitLab dev/internal Other internal work that does not need to be included in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants