-
Notifications
You must be signed in to change notification settings - Fork 399
Use better type definitions for OT baggage module #5155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Typing analysisNote: Ignored files are excluded from the next sections. Untyped methodsThis PR clears 1 untyped method and 4 partially typed methods. It increases the percentage of typed methods from 55.39% to 55.69% (+0.3%). Untyped methods (+0-1)✅ Cleared:Partially typed methods (+0-4)✅ Cleared: |
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: c1f106e | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
ivoanjo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
* commit 'a4c17f9fb9a19946b4ae099ad894c4e50c68ce81': (25 commits) improve diagnostics of "leaked" file descriptors for jruby DEBUG-4548 Core: fix worker shutdown race (#5176) Retry system-test build (#5181) Fix Baggage type check (#5182) [🤖] Update System Tests: https://github.com/DataDog/dd-trace-rb/actions/runs/20487829791 (#5183) [🤖] Update Latest Dependency: https://github.com/DataDog/dd-trace-rb/actions/runs/20401889084 (#5180) DEBUG-3499 DI: do not instrument when there is already an installed probe with the same id (#5169) DEBUG-3499 DI: rework RC interface (#5165) set DI test duration upper bound to 1000 seconds (#5161) add missing supported config default value [🤖] Update System Tests: https://github.com/DataDog/dd-trace-rb/actions/runs/20401907816 (#5179) Use better type definitions for OT baggage module (#5155) normalize headers new default for OTEL_EXPORTER_OTLP_METRICS_PROTOCOL clean up config docs remove protocol from exporter args do not hardcode env look up add test case and fix origin clean up get_metrics_config_with_fallback remove default value ...
What does this PR do?
This PR adds better type definitions for
OpenTelemetry::Baggagefrom the file that was deleted in #5145.Motivation:
This is a separate PR, since there was a small problem that was detected by steep and had to be fixed.
Change log entry
None.
Additional Notes:
None.
How to test the change?
CI.