Skip to content

Conversation

@y9v
Copy link
Member

@y9v y9v commented Dec 16, 2025

What does this PR do?
This PR adds better type definitions for OpenTelemetry::Baggage from the file that was deleted in #5145.

Motivation:
This is a separate PR, since there was a small problem that was detected by steep and had to be fixed.

Change log entry
None.

Additional Notes:
None.

How to test the change?
CI.

@y9v y9v self-assigned this Dec 16, 2025
@y9v y9v requested review from a team as code owners December 16, 2025 10:00
@y9v y9v requested a review from mabdinur December 16, 2025 10:00
@github-actions github-actions bot added the otel OpenTelemetry-related changes label Dec 16, 2025
@github-actions
Copy link

Typing analysis

Note: Ignored files are excluded from the next sections.

Untyped methods

This PR clears 1 untyped method and 4 partially typed methods. It increases the percentage of typed methods from 55.39% to 55.69% (+0.3%).

Untyped methods (+0-1)Cleared:
sig/datadog/opentelemetry/api/baggage.rbs:9
└── def clear: (?context: untyped) -> untyped
Partially typed methods (+0-4)Cleared:
sig/datadog/opentelemetry/api/baggage.rbs:11
└── def value: (String key, ?context: untyped) -> String?
sig/datadog/opentelemetry/api/baggage.rbs:13
└── def values: (?context: untyped) -> Hash[String, String]
sig/datadog/opentelemetry/api/baggage.rbs:15
└── def set_value: (String key, String value, ?metadata: String?, ?context: untyped) -> untyped
sig/datadog/opentelemetry/api/baggage.rbs:17
└── def remove_value: (String key, ?context: untyped) -> untyped

@datadog-official
Copy link

datadog-official bot commented Dec 16, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 100.00%
Overall Coverage: 95.23% (+0.00%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c1f106e | Docs | Datadog PR Page | Was this helpful? Give us feedback!

Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@marcotc marcotc merged commit 96a6bd8 into master Dec 23, 2025
554 checks passed
@marcotc marcotc deleted the improve-types-for-ot-baggage branch December 23, 2025 00:26
@github-actions github-actions bot added this to the 2.24.0 milestone Dec 23, 2025
@marcotc marcotc mentioned this pull request Dec 24, 2025
p-datadog pushed a commit that referenced this pull request Dec 29, 2025
* commit 'a4c17f9fb9a19946b4ae099ad894c4e50c68ce81': (25 commits)
  improve diagnostics of "leaked" file descriptors for jruby
  DEBUG-4548 Core: fix worker shutdown race  (#5176)
  Retry system-test build (#5181)
  Fix Baggage type check (#5182)
  [🤖] Update System Tests: https://github.com/DataDog/dd-trace-rb/actions/runs/20487829791 (#5183)
  [🤖] Update Latest Dependency: https://github.com/DataDog/dd-trace-rb/actions/runs/20401889084 (#5180)
  DEBUG-3499 DI: do not instrument when there is already an installed probe with the same id (#5169)
  DEBUG-3499 DI: rework RC interface (#5165)
  set DI test duration upper bound to 1000 seconds (#5161)
  add missing supported config default value
  [🤖] Update System Tests: https://github.com/DataDog/dd-trace-rb/actions/runs/20401907816 (#5179)
  Use better type definitions for OT baggage module (#5155)
  normalize headers
  new default for OTEL_EXPORTER_OTLP_METRICS_PROTOCOL
  clean up config docs
  remove protocol from exporter args
  do not hardcode env look up
  add test case and fix origin
  clean up get_metrics_config_with_fallback
  remove default value
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

otel OpenTelemetry-related changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants