-
Notifications
You must be signed in to change notification settings - Fork 398
RC: Add process tags to remote configuration payloads #5126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… be under application instead.
marcotc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, with @p-datadog's suggestion implemented.
…r the difference in memoization
…the tests are consistent across testing environments
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: 02fc9d8 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
…ec and process_spec because they test on the same mocked process environment
Strech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to suggest a tiny change
What does this PR do?
Adds process tags to the dynamic instrumentation payloads, similar to these two PRs:
Note In both of those the remote configuration payload required the process tags to be an array so there's now a new method in Process.rb to do this.
Motivation:
For https://datadoghq.atlassian.net/browse/AIDM-257
Change log entry
None.
Additional Notes:
Note: This PR should not be merged until #5110 gets merged
How to test the change?
I've been running: