Skip to content

Conversation

@wantsui
Copy link
Collaborator

@wantsui wantsui commented Dec 9, 2025

What does this PR do?

Adds process tags to the dynamic instrumentation payloads, similar to these two PRs:

Note In both of those the remote configuration payload required the process tags to be an array so there's now a new method in Process.rb to do this.

Motivation:

For https://datadoghq.atlassian.net/browse/AIDM-257

Change log entry

None.

Additional Notes:

Note: This PR should not be merged until #5110 gets merged

How to test the change?

I've been running:

docker compose run --rm tracer-3.3 /bin/bash
bundle exec rspec spec/datadog/core/remote/client_spec.rb
bundle exec rspec spec/datadog/core/environment/process_spec.rb

@github-actions github-actions bot added the core Involves Datadog core libraries label Dec 9, 2025
@wantsui wantsui added AI Generated Largely based on code generated by an AI or LLM. This label is the same across all dd-trace-* repos and removed core Involves Datadog core libraries labels Dec 9, 2025
@wantsui wantsui requested a review from marcotc December 9, 2025 23:08
@pr-commenter
Copy link

pr-commenter bot commented Dec 9, 2025

Benchmarks

Benchmark execution time: 2025-12-16 15:45:07

Comparing candidate commit 02fc9d8 in PR branch add-process-tags-rc with baseline commit f19d88e in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 2 unstable metrics.

@wantsui wantsui marked this pull request as ready for review December 10, 2025 13:59
@wantsui wantsui requested a review from a team as a code owner December 10, 2025 13:59
Copy link
Member

@marcotc marcotc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, with @p-datadog's suggestion implemented.

@github-actions github-actions bot added the core Involves Datadog core libraries label Dec 10, 2025
@wantsui wantsui requested a review from p-datadog December 10, 2025 21:28
Base automatically changed from add-process-tags-to-telemetry to master December 15, 2025 20:34
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Dec 15, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 100.00%
Overall Coverage: 95.23% (-0.00%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 02fc9d8 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

…ec and process_spec because they test on the same mocked process environment
Copy link
Member

@Strech Strech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to suggest a tiny change

@wantsui wantsui merged commit 1970b95 into master Dec 16, 2025
553 checks passed
@wantsui wantsui deleted the add-process-tags-rc branch December 16, 2025 17:58
@github-actions github-actions bot added this to the 2.24.0 milestone Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Generated Largely based on code generated by an AI or LLM. This label is the same across all dd-trace-* repos core Involves Datadog core libraries

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants