Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 226 ± 3 ms. The average import time from base is: 228 ± 3 ms. The import time difference between this PR and base is: -2.4 ± 0.1 ms. Import time breakdownThe following import paths have grown:
|
Performance SLOsComparing candidate dubloom/process-tags-remote-config (43d8697) with baseline main (38155b3) 🟡 Near SLO Breach (2 suites)🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.600ms (SLO: <4.750ms -3.2%) vs baseline: ~same Memory: ✅ 63.962MB (SLO: <66.500MB -3.8%) vs baseline: +4.6% ✅ appsec-postTime: ✅ 6.626ms (SLO: <6.750ms 🟡 -1.8%) vs baseline: ~same Memory: ✅ 64.317MB (SLO: <66.500MB -3.3%) vs baseline: +4.7% ✅ appsec-telemetryTime: ✅ 4.583ms (SLO: <4.750ms -3.5%) vs baseline: -0.1% Memory: ✅ 64.062MB (SLO: <66.500MB -3.7%) vs baseline: +4.9% ✅ debuggerTime: ✅ 1.853ms (SLO: <2.000ms -7.3%) vs baseline: -0.5% Memory: ✅ 47.863MB (SLO: <49.500MB -3.3%) vs baseline: +4.8% ✅ iast-getTime: ✅ 1.856ms (SLO: <2.000ms -7.2%) vs baseline: ~same Memory: ✅ 44.734MB (SLO: <49.000MB -8.7%) vs baseline: +4.9% ✅ profilerTime: ✅ 1.924ms (SLO: <2.100ms -8.4%) vs baseline: -0.2% Memory: ✅ 48.357MB (SLO: <50.000MB -3.3%) vs baseline: +4.7% ✅ resource-renamingTime: ✅ 3.371ms (SLO: <3.650ms -7.6%) vs baseline: ~same Memory: ✅ 54.711MB (SLO: <56.000MB -2.3%) vs baseline: +4.8% ✅ tracerTime: ✅ 3.364ms (SLO: <3.650ms -7.8%) vs baseline: -0.3% Memory: ✅ 54.587MB (SLO: <56.500MB -3.4%) vs baseline: +4.5% ✅ tracer-nativeTime: ✅ 3.364ms (SLO: <3.650ms -7.8%) vs baseline: -0.1% Memory: ✅ 54.630MB (SLO: <60.000MB -9.0%) vs baseline: +4.7% 🟡 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 2.936µs (SLO: <20.000µs 📉 -85.3%) vs baseline: -0.6% Memory: ✅ 34.623MB (SLO: <35.500MB -2.5%) vs baseline: +4.8% ✅ 1-count-metrics-100-timesTime: ✅ 200.127µs (SLO: <220.000µs -9.0%) vs baseline: +0.2% Memory: ✅ 34.544MB (SLO: <35.500MB -2.7%) vs baseline: +4.8% ✅ 1-distribution-metric-1-timesTime: ✅ 3.370µs (SLO: <20.000µs 📉 -83.1%) vs baseline: +1.8% Memory: ✅ 34.662MB (SLO: <35.500MB -2.4%) vs baseline: +5.2% ✅ 1-distribution-metrics-100-timesTime: ✅ 217.658µs (SLO: <230.000µs -5.4%) vs baseline: -1.1% Memory: ✅ 34.623MB (SLO: <35.500MB -2.5%) vs baseline: +4.8% ✅ 1-gauge-metric-1-timesTime: ✅ 2.155µs (SLO: <20.000µs 📉 -89.2%) vs baseline: -1.1% Memory: ✅ 34.564MB (SLO: <35.500MB -2.6%) vs baseline: +4.9% ✅ 1-gauge-metrics-100-timesTime: ✅ 135.877µs (SLO: <150.000µs -9.4%) vs baseline: -0.5% Memory: ✅ 34.583MB (SLO: <35.500MB -2.6%) vs baseline: +4.8% ✅ 1-rate-metric-1-timesTime: ✅ 3.149µs (SLO: <20.000µs 📉 -84.3%) vs baseline: +2.4% Memory: ✅ 34.623MB (SLO: <35.500MB -2.5%) vs baseline: +4.9% ✅ 1-rate-metrics-100-timesTime: ✅ 214.023µs (SLO: <250.000µs 📉 -14.4%) vs baseline: -0.2% Memory: ✅ 34.544MB (SLO: <35.500MB -2.7%) vs baseline: +4.8% ✅ 100-count-metrics-100-timesTime: ✅ 20.161ms (SLO: <22.000ms -8.4%) vs baseline: +1.8% Memory: ✅ 34.642MB (SLO: <35.500MB -2.4%) vs baseline: +4.9% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.258ms (SLO: <2.300ms 🟡 -1.8%) vs baseline: -1.1% Memory: ✅ 34.583MB (SLO: <35.500MB -2.6%) vs baseline: +4.8% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.408ms (SLO: <1.550ms -9.1%) vs baseline: +0.2% Memory: ✅ 34.642MB (SLO: <35.500MB -2.4%) vs baseline: +4.9% ✅ 100-rate-metrics-100-timesTime: ✅ 2.196ms (SLO: <2.550ms 📉 -13.9%) vs baseline: +1.3% Memory: ✅ 34.603MB (SLO: <35.500MB -2.5%) vs baseline: +5.0% ✅ flush-1-metricTime: ✅ 4.643µs (SLO: <20.000µs 📉 -76.8%) vs baseline: +0.3% Memory: ✅ 34.583MB (SLO: <35.500MB -2.6%) vs baseline: +4.7% ✅ flush-100-metricsTime: ✅ 173.217µs (SLO: <250.000µs 📉 -30.7%) vs baseline: ~same Memory: ✅ 34.603MB (SLO: <35.500MB -2.5%) vs baseline: +4.7% ✅ flush-1000-metricsTime: ✅ 2.116ms (SLO: <2.500ms 📉 -15.4%) vs baseline: ~same Memory: ✅ 35.370MB (SLO: <36.500MB -3.1%) vs baseline: +4.7%
|
39b6254 to
8c6a18a
Compare
…ags-remote-config
KowalskiThomas
left a comment
There was a problem hiding this comment.
Not a lot of context here but what I see does seem to make sense to me.
This PR implements this RFC for remote.
Add process_tags to remote config payload. Note that remote config needs an array and not a string of value. We also retest that the right values are set.
Testing