Skip to content

Commit

Permalink
add descriptions for skipped tests, and remove max pytest version
Browse files Browse the repository at this point in the history
Update test_frameworks.yml

fix(typing): botocore.get_kinesis_data_object (#3641)

Fix type error. #3640

add descriptions for skipped tests, and remove max pytest version
  • Loading branch information
mabdinur committed Apr 29, 2022
1 parent 25fa620 commit d576e37
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 6 deletions.
15 changes: 11 additions & 4 deletions .github/workflows/test_frameworks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -113,16 +113,23 @@ jobs:
path: graphene
- uses: actions/setup-python@v3
with:
python-version: "3.8"
python-version: "3.10"
- name: Install ddtrace
run: pip install ../ddtrace
- name: Install graphene
run: pip install ../graphene
run: pip install -e "../graphene[test]"
- name: "Upgrade pytest"
# pytest<6.2.5 raises `TypeError: required field "lineno" missing from alias` on python 3.10
run: pip install "pytest>=6.2.5,<7"
- name: Set Pythonpath
run: echo "PYTHONPATH=." >> $GITHUB_ENV
- name: Run tests
# django.tests.requests module interferes with requests library patching in the tracer -> disable requests patch
run: DD_TRACE_REQUESTS_ENABLED=0 ddtrace-run py.test .
# The following tests are broken and will be skipped in this framework test
# test_node_query_incorrect_id - failure: "Unable to parse global ID .*" != "Relay Node "" not found in schema"
# test_objecttype_as_container_extra_args - failure: "__init__() takes from 1 to 3 positional arguments but 4 were given" != "Container.__init__() takes from 1 to 3 positional arguments but 4 were given"
# test_objecttype_as_container_invalid_kwargs - failure: "__init__() got an unexpected keyword argument 'unexisting_field'" != "Container.__init__() got an unexpected keyword argument 'unexisting_field'"
# test_example_end_to_end - failure: result.errors != [], result.errors -> [GraphQLError('ID cannot represent......]
run: ddtrace-run pytest graphene -k 'not test_node_query_incorrect_id and not test_objecttype_as_container_invalid_kwargs and not test_example_end_to_end and not test_objecttype_as_container_extra_args'

fastapi-testsuite-0_75:
runs-on: ubuntu-latest
Expand Down
3 changes: 1 addition & 2 deletions ddtrace/contrib/botocore/patch.py
Original file line number Diff line number Diff line change
Expand Up @@ -161,10 +161,9 @@ def inject_trace_to_eventbridge_detail(params, span):


def get_kinesis_data_object(data):
# type: (str, Optional[bool]) -> Optional[Dict[str, Any]]
# type: (str) -> Optional[Dict[str, Any]]
"""
:data: the data from a kinesis stream
:try_b64: whether we should try to decode the string as base64
The data from a kinesis stream comes as a string (could be json, base64 encoded, etc.)
We support injecting our trace context in the following two cases:
Expand Down

0 comments on commit d576e37

Please sign in to comment.