chore: remove the aioredis integration #15253
Conversation
brettlangdon
requested review from
ZStriker19,
avara1986,
emmettbutler and
wconti27
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 207 ± 2 ms. The average import time from base is: 212 ± 2 ms. The import time difference between this PR and base is: -5.5 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate brettlangdon/remove.aioredis (3bd179b) with baseline main (3576477) 🟡 Near SLO Breach (5 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 19.228ms (SLO: <22.300ms 📉 -13.8%) vs baseline: ~same Memory: ✅ 65.997MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.8% ✅ exception-replay-enabledTime: ✅ 1.343ms (SLO: <1.450ms -7.3%) vs baseline: +0.3% Memory: ✅ 64.148MB (SLO: <67.000MB -4.3%) vs baseline: +4.8% ✅ iastTime: ✅ 19.266ms (SLO: <22.250ms 📉 -13.4%) vs baseline: +0.1% Memory: ✅ 65.981MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.9% ✅ profilerTime: ✅ 15.368ms (SLO: <16.550ms -7.1%) vs baseline: ~same Memory: ✅ 53.944MB (SLO: <54.500MB 🟡 -1.0%) vs baseline: +5.0% ✅ resource-renamingTime: ✅ 19.292ms (SLO: <21.750ms 📉 -11.3%) vs baseline: -0.2% Memory: ✅ 65.997MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.9% ✅ span-code-originTime: ✅ 22.816ms (SLO: <28.200ms 📉 -19.1%) vs baseline: -0.1% Memory: ✅ 67.292MB (SLO: <69.500MB -3.2%) vs baseline: +5.1% ✅ tracerTime: ✅ 19.236ms (SLO: <21.750ms 📉 -11.6%) vs baseline: -0.3% Memory: ✅ 65.964MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.9% ✅ tracer-and-profilerTime: ✅ 21.119ms (SLO: <23.500ms 📉 -10.1%) vs baseline: +0.1% Memory: ✅ 67.746MB (SLO: <68.000MB 🟡 -0.4%) vs baseline: +4.9% ✅ tracer-dont-create-db-spansTime: ✅ 19.286ms (SLO: <21.500ms 📉 -10.3%) vs baseline: +0.2% Memory: ✅ 65.964MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.9% ✅ tracer-minimalTime: ✅ 16.659ms (SLO: <17.500ms -4.8%) vs baseline: +0.7% Memory: ✅ 66.044MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 19.281ms (SLO: <21.750ms 📉 -11.4%) vs baseline: ~same Memory: ✅ 67.738MB (SLO: <72.500MB -6.6%) vs baseline: +4.9% ✅ tracer-no-cachesTime: ✅ 17.318ms (SLO: <19.650ms 📉 -11.9%) vs baseline: +0.2% Memory: ✅ 65.931MB (SLO: <67.000MB 🟡 -1.6%) vs baseline: +4.7% ✅ tracer-no-databasesTime: ✅ 18.762ms (SLO: <20.100ms -6.7%) vs baseline: +0.3% Memory: ✅ 65.964MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.8% ✅ tracer-no-middlewareTime: ✅ 18.987ms (SLO: <21.500ms 📉 -11.7%) vs baseline: +0.3% Memory: ✅ 65.965MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.9% ✅ tracer-no-templatesTime: ✅ 19.061ms (SLO: <22.000ms 📉 -13.4%) vs baseline: ~same Memory: ✅ 66.087MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +5.1% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 16.466ms (SLO: <19.850ms 📉 -17.1%) vs baseline: +0.9% Memory: ✅ 65.834MB (SLO: <66.500MB 🟡 -1.0%) vs baseline: +5.2% ✅ errortracking-enabled-userTime: ✅ 16.447ms (SLO: <19.400ms 📉 -15.2%) vs baseline: +0.9% Memory: ✅ 65.746MB (SLO: <66.500MB 🟡 -1.1%) vs baseline: +5.1% ✅ tracer-enabledTime: ✅ 16.401ms (SLO: <19.450ms 📉 -15.7%) vs baseline: +0.8% Memory: ✅ 65.613MB (SLO: <66.500MB 🟡 -1.3%) vs baseline: +4.7% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.585ms (SLO: <4.750ms -3.5%) vs baseline: -0.4% Memory: ✅ 62.045MB (SLO: <65.000MB -4.5%) vs baseline: +5.0% ✅ appsec-postTime: ✅ 6.601ms (SLO: <6.750ms -2.2%) vs baseline: -0.5% Memory: ✅ 62.103MB (SLO: <65.000MB -4.5%) vs baseline: +4.7% ✅ appsec-telemetryTime: ✅ 4.574ms (SLO: <4.750ms -3.7%) vs baseline: +0.2% Memory: ✅ 62.066MB (SLO: <65.000MB -4.5%) vs baseline: +4.9% ✅ debuggerTime: ✅ 1.854ms (SLO: <2.000ms -7.3%) vs baseline: -0.1% Memory: ✅ 45.181MB (SLO: <47.000MB -3.9%) vs baseline: +4.7% ✅ iast-getTime: ✅ 1.857ms (SLO: <2.000ms -7.2%) vs baseline: -0.3% Memory: ✅ 41.870MB (SLO: <49.000MB 📉 -14.6%) vs baseline: +5.0% ✅ profilerTime: ✅ 1.912ms (SLO: <2.100ms -9.0%) vs baseline: -0.4% Memory: ✅ 46.478MB (SLO: <47.000MB 🟡 -1.1%) vs baseline: +4.7% ✅ resource-renamingTime: ✅ 3.368ms (SLO: <3.650ms -7.7%) vs baseline: -0.2% Memory: ✅ 52.435MB (SLO: <53.500MB 🟡 -2.0%) vs baseline: +4.8% ✅ tracerTime: ✅ 3.356ms (SLO: <3.650ms -8.1%) vs baseline: -0.3% Memory: ✅ 52.435MB (SLO: <53.500MB 🟡 -2.0%) vs baseline: +4.6% ✅ tracer-nativeTime: ✅ 3.358ms (SLO: <3.650ms -8.0%) vs baseline: +0.3% Memory: ✅ 54.082MB (SLO: <60.000MB -9.9%) vs baseline: +5.0% 🟡 otelspan - 22/22✅ add-eventTime: ✅ 38.631ms (SLO: <47.150ms 📉 -18.1%) vs baseline: -0.1% Memory: ✅ 36.399MB (SLO: <47.000MB 📉 -22.6%) vs baseline: +4.7% ✅ add-metricsTime: ✅ 259.003ms (SLO: <344.800ms 📉 -24.9%) vs baseline: +0.4% Memory: ✅ 40.679MB (SLO: <47.500MB 📉 -14.4%) vs baseline: +4.9% ✅ add-tagsTime: ✅ 316.885ms (SLO: <321.000ms 🟡 -1.3%) vs baseline: +0.1% Memory: ✅ 40.797MB (SLO: <47.500MB 📉 -14.1%) vs baseline: +5.1% ✅ get-contextTime: ✅ 78.736ms (SLO: <92.350ms 📉 -14.7%) vs baseline: +0.2% Memory: ✅ 36.699MB (SLO: <46.500MB 📉 -21.1%) vs baseline: +4.6% ✅ is-recordingTime: ✅ 36.161ms (SLO: <44.500ms 📉 -18.7%) vs baseline: -0.2% Memory: ✅ 36.216MB (SLO: <47.500MB 📉 -23.8%) vs baseline: +5.1% ✅ record-exceptionTime: ✅ 57.131ms (SLO: <67.650ms 📉 -15.5%) vs baseline: +0.2% Memory: ✅ 36.901MB (SLO: <47.000MB 📉 -21.5%) vs baseline: +4.8% ✅ set-statusTime: ✅ 42.367ms (SLO: <50.400ms 📉 -15.9%) vs baseline: +0.3% Memory: ✅ 36.220MB (SLO: <47.000MB 📉 -22.9%) vs baseline: +5.6% ✅ startTime: ✅ 35.571ms (SLO: <43.450ms 📉 -18.1%) vs baseline: +0.5% Memory: ✅ 36.184MB (SLO: <47.000MB 📉 -23.0%) vs baseline: +4.8% ✅ start-finishTime: ✅ 81.569ms (SLO: <88.000ms -7.3%) vs baseline: +0.3% Memory: ✅ 33.994MB (SLO: <46.500MB 📉 -26.9%) vs baseline: +4.7% ✅ start-finish-telemetryTime: ✅ 83.019ms (SLO: <89.000ms -6.7%) vs baseline: +0.1% Memory: ✅ 34.053MB (SLO: <46.500MB 📉 -26.8%) vs baseline: +5.0% ✅ update-nameTime: ✅ 36.809ms (SLO: <45.150ms 📉 -18.5%) vs baseline: -0.1% Memory: ✅ 36.357MB (SLO: <47.000MB 📉 -22.6%) vs baseline: +4.8% 🟡 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 2.986µs (SLO: <20.000µs 📉 -85.1%) vs baseline: -0.2% Memory: ✅ 31.516MB (SLO: <34.000MB -7.3%) vs baseline: +4.9% ✅ 1-count-metrics-100-timesTime: ✅ 201.984µs (SLO: <220.000µs -8.2%) vs baseline: ~same Memory: ✅ 31.497MB (SLO: <34.000MB -7.4%) vs baseline: +4.7% ✅ 1-distribution-metric-1-timesTime: ✅ 3.598µs (SLO: <20.000µs 📉 -82.0%) vs baseline: +7.4% Memory: ✅ 31.516MB (SLO: <34.000MB -7.3%) vs baseline: +4.6% ✅ 1-distribution-metrics-100-timesTime: ✅ 214.664µs (SLO: <220.000µs -2.4%) vs baseline: -0.5% Memory: ✅ 31.536MB (SLO: <34.000MB -7.2%) vs baseline: +4.8% ✅ 1-gauge-metric-1-timesTime: ✅ 2.213µs (SLO: <20.000µs 📉 -88.9%) vs baseline: -0.4% Memory: ✅ 31.575MB (SLO: <34.000MB -7.1%) vs baseline: +5.1% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.603µs (SLO: <150.000µs -8.9%) vs baseline: -0.8% Memory: ✅ 31.536MB (SLO: <34.000MB -7.2%) vs baseline: +4.7% ✅ 1-rate-metric-1-timesTime: ✅ 3.164µs (SLO: <20.000µs 📉 -84.2%) vs baseline: +0.8% Memory: ✅ 31.497MB (SLO: <34.000MB -7.4%) vs baseline: +4.9% ✅ 1-rate-metrics-100-timesTime: ✅ 214.400µs (SLO: <250.000µs 📉 -14.2%) vs baseline: -1.1% Memory: ✅ 31.497MB (SLO: <34.000MB -7.4%) vs baseline: +4.8% ✅ 100-count-metrics-100-timesTime: ✅ 20.312ms (SLO: <22.000ms -7.7%) vs baseline: -1.3% Memory: ✅ 31.516MB (SLO: <34.000MB -7.3%) vs baseline: +4.7% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.282ms (SLO: <2.300ms 🟡 -0.8%) vs baseline: +1.5% Memory: ✅ 31.457MB (SLO: <34.000MB -7.5%) vs baseline: +3.3% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.410ms (SLO: <1.550ms -9.0%) vs baseline: +0.6% Memory: ✅ 31.497MB (SLO: <34.000MB -7.4%) vs baseline: +4.9% ✅ 100-rate-metrics-100-timesTime: ✅ 2.219ms (SLO: <2.550ms 📉 -13.0%) vs baseline: -0.8% Memory: ✅ 31.497MB (SLO: <34.000MB -7.4%) vs baseline: +4.9% ✅ flush-1-metricTime: ✅ 4.850µs (SLO: <20.000µs 📉 -75.7%) vs baseline: +6.8% Memory: ✅ 31.949MB (SLO: <34.000MB -6.0%) vs baseline: +5.0% ✅ flush-100-metricsTime: ✅ 174.905µs (SLO: <250.000µs 📉 -30.0%) vs baseline: -0.8% Memory: ✅ 31.929MB (SLO: <34.000MB -6.1%) vs baseline: +4.9% ✅ flush-1000-metricsTime: ✅ 2.122ms (SLO: <2.500ms 📉 -15.1%) vs baseline: ~same Memory: ✅ 32.755MB (SLO: <34.500MB -5.1%) vs baseline: +5.0%
|
## Description Has been deprecated for awhile, this finally removes it. ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> (cherry picked from commit 53d95a7)
## Description Has been deprecated for awhile, this finally removes it. ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> (cherry picked from commit 53d95a7)
## Description Has been deprecated for awhile, this finally removes it. ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> (cherry picked from commit 53d95a7)
## Description #15253 removed aioredis integration folders but did not touch the integration registry, this meant the checks on the integration registry never ran and didn't catch that we didn't remove aioredis integration entirely. This change updates the definition for the "contrib" component to be more inclusive of all contrib files. ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> --------- Co-authored-by: Emmett Butler <[email protected]>
#15253 removed aioredis integration folders but did not touch the integration registry, this meant the checks on the integration registry never ran and didn't catch that we didn't remove aioredis integration entirely. This change updates the definition for the "contrib" component to be more inclusive of all contrib files. <!-- Describe your testing strategy or note what tests are included --> <!-- Note any risks associated with this change, or "None" if no risks --> <!-- Any other information that would be helpful for reviewers --> --------- Co-authored-by: Emmett Butler <[email protected]> (cherry picked from commit be7f4cb)
#15253 removed aioredis integration folders but did not touch the integration registry, this meant the checks on the integration registry never ran and didn't catch that we didn't remove aioredis integration entirely. This change updates the definition for the "contrib" component to be more inclusive of all contrib files. <!-- Describe your testing strategy or note what tests are included --> <!-- Note any risks associated with this change, or "None" if no risks --> <!-- Any other information that would be helpful for reviewers --> --------- (cherry picked from commit be7f4cb) Co-authored-by: Brett Langdon <[email protected]>
Backport 53d95a7 from #15253 to 4.0. ## Description Has been deprecated for awhile, this finally removes it. ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> --------- Co-authored-by: Brett Langdon <[email protected]>
## Description #15253 removed aioredis integration folders, but was missing updating the registry and monkey.py. ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> Co-authored-by: Emmett Butler <[email protected]>
## Description #15253 removed aioredis integration folders, but was missing updating the registry and monkey.py. ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> Co-authored-by: Emmett Butler <[email protected]>
Description
Has been deprecated for awhile, this finally removes it.
Testing
Risks
Additional Notes