-
Notifications
You must be signed in to change notification settings - Fork 470
chore(logging): remove log correlation attributes from ddtrace loggers [Take 2] [backport 3.17] #15044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
19d5d8c to
daf7d9b
Compare
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 206 ± 2 ms. The average import time from base is: 208 ± 2 ms. The import time difference between this PR and base is: -1.9 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate backport-15036-to-3.17 (4ab2dea) with baseline 3.17 (1769c04) 🟡 Near SLO Breach (4 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.445ms (SLO: <22.300ms -8.3%) vs baseline: ~same Memory: ✅ 65.394MB (SLO: <67.000MB -2.4%) vs baseline: +4.7% ✅ exception-replay-enabledTime: ✅ 1.345ms (SLO: <1.450ms -7.3%) vs baseline: ~same Memory: ✅ 64.552MB (SLO: <67.000MB -3.7%) vs baseline: +4.9% ✅ iastTime: ✅ 20.513ms (SLO: <22.250ms -7.8%) vs baseline: +0.5% Memory: ✅ 65.363MB (SLO: <67.000MB -2.4%) vs baseline: +4.6% ✅ profilerTime: ✅ 15.238ms (SLO: <16.550ms -7.9%) vs baseline: +0.1% Memory: ✅ 53.693MB (SLO: <54.500MB 🟡 -1.5%) vs baseline: +4.9% ✅ resource-renamingTime: ✅ 20.548ms (SLO: <21.750ms -5.5%) vs baseline: ~same Memory: ✅ 65.464MB (SLO: <67.000MB -2.3%) vs baseline: +4.8% ✅ span-code-originTime: ✅ 25.326ms (SLO: <28.200ms 📉 -10.2%) vs baseline: +1.3% Memory: ✅ 67.526MB (SLO: <69.500MB -2.8%) vs baseline: +4.6% ✅ tracerTime: ✅ 20.461ms (SLO: <21.750ms -5.9%) vs baseline: -0.1% Memory: ✅ 65.346MB (SLO: <67.000MB -2.5%) vs baseline: +4.7% ✅ tracer-and-profilerTime: ✅ 21.973ms (SLO: <23.500ms -6.5%) vs baseline: -0.2% Memory: ✅ 66.768MB (SLO: <67.500MB 🟡 -1.1%) vs baseline: +5.1% ✅ tracer-dont-create-db-spansTime: ✅ 19.273ms (SLO: <21.500ms 📉 -10.4%) vs baseline: -0.2% Memory: ✅ 65.422MB (SLO: <66.000MB 🟡 -0.9%) vs baseline: +4.8% ✅ tracer-minimalTime: ✅ 16.602ms (SLO: <17.500ms -5.1%) vs baseline: -0.3% Memory: ✅ 65.372MB (SLO: <66.000MB 🟡 -1.0%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 20.542ms (SLO: <21.750ms -5.6%) vs baseline: +0.1% Memory: ✅ 71.483MB (SLO: <72.500MB 🟡 -1.4%) vs baseline: +4.9% ✅ tracer-no-cachesTime: ✅ 18.423ms (SLO: <19.650ms -6.2%) vs baseline: -0.1% Memory: ✅ 65.350MB (SLO: <67.000MB -2.5%) vs baseline: +4.7% ✅ tracer-no-databasesTime: ✅ 18.850ms (SLO: <20.100ms -6.2%) vs baseline: +0.6% Memory: ✅ 65.320MB (SLO: <67.000MB -2.5%) vs baseline: +4.8% ✅ tracer-no-middlewareTime: ✅ 20.181ms (SLO: <21.500ms -6.1%) vs baseline: +0.3% Memory: ✅ 65.382MB (SLO: <67.000MB -2.4%) vs baseline: +4.7% ✅ tracer-no-templatesTime: ✅ 20.293ms (SLO: <22.000ms -7.8%) vs baseline: +0.2% Memory: ✅ 65.378MB (SLO: <67.000MB -2.4%) vs baseline: +4.7% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.023ms (SLO: <19.850ms -9.2%) vs baseline: +0.2% Memory: ✅ 65.215MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ errortracking-enabled-userTime: ✅ 18.187ms (SLO: <19.400ms -6.3%) vs baseline: +1.1% Memory: ✅ 65.274MB (SLO: <66.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ tracer-enabledTime: ✅ 18.130ms (SLO: <19.450ms -6.8%) vs baseline: +0.3% Memory: ✅ 65.252MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.8% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.582ms (SLO: <4.750ms -3.5%) vs baseline: -0.6% Memory: ✅ 61.932MB (SLO: <65.000MB -4.7%) vs baseline: +4.8% ✅ appsec-postTime: ✅ 6.598ms (SLO: <6.750ms -2.3%) vs baseline: -0.2% Memory: ✅ 62.049MB (SLO: <65.000MB -4.5%) vs baseline: +5.1% ✅ appsec-telemetryTime: ✅ 4.581ms (SLO: <4.750ms -3.6%) vs baseline: -0.7% Memory: ✅ 61.941MB (SLO: <65.000MB -4.7%) vs baseline: +4.9% ✅ debuggerTime: ✅ 1.857ms (SLO: <2.000ms -7.1%) vs baseline: +0.3% Memory: ✅ 45.416MB (SLO: <47.000MB -3.4%) vs baseline: +4.9% ✅ iast-getTime: ✅ 1.861ms (SLO: <2.000ms -6.9%) vs baseline: -0.2% Memory: ✅ 42.369MB (SLO: <49.000MB 📉 -13.5%) vs baseline: +4.7% ✅ profilerTime: ✅ 1.910ms (SLO: <2.100ms -9.0%) vs baseline: -0.2% Memory: ✅ 46.458MB (SLO: <47.000MB 🟡 -1.2%) vs baseline: +5.0% ✅ resource-renamingTime: ✅ 3.371ms (SLO: <3.650ms -7.6%) vs baseline: -0.6% Memory: ✅ 52.321MB (SLO: <53.500MB -2.2%) vs baseline: +5.1% ✅ tracerTime: ✅ 3.352ms (SLO: <3.650ms -8.2%) vs baseline: -0.7% Memory: ✅ 52.199MB (SLO: <53.500MB -2.4%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 3.353ms (SLO: <3.650ms -8.1%) vs baseline: -0.4% Memory: ✅ 58.248MB (SLO: <60.000MB -2.9%) vs baseline: +4.9% 🟡 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 2.970µs (SLO: <20.000µs 📉 -85.2%) vs baseline: -0.1% Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +4.8% ✅ 1-count-metrics-100-timesTime: ✅ 202.251µs (SLO: <220.000µs -8.1%) vs baseline: -0.6% Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +5.1% ✅ 1-distribution-metric-1-timesTime: ✅ 3.301µs (SLO: <20.000µs 📉 -83.5%) vs baseline: -0.4% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +5.1% ✅ 1-distribution-metrics-100-timesTime: ✅ 213.942µs (SLO: <220.000µs -2.8%) vs baseline: -0.7% Memory: ✅ 32.086MB (SLO: <34.000MB -5.6%) vs baseline: +4.7% ✅ 1-gauge-metric-1-timesTime: ✅ 2.369µs (SLO: <20.000µs 📉 -88.2%) vs baseline: +8.0% Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +5.0% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.848µs (SLO: <150.000µs -8.8%) vs baseline: -0.8% Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +4.9% ✅ 1-rate-metric-1-timesTime: ✅ 3.043µs (SLO: <20.000µs 📉 -84.8%) vs baseline: -1.8% Memory: ✅ 32.086MB (SLO: <34.000MB -5.6%) vs baseline: +4.7% ✅ 1-rate-metrics-100-timesTime: ✅ 218.059µs (SLO: <250.000µs 📉 -12.8%) vs baseline: +1.2% Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +4.7% ✅ 100-count-metrics-100-timesTime: ✅ 20.814ms (SLO: <22.000ms -5.4%) vs baseline: -0.9% Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +4.9% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.259ms (SLO: <2.300ms 🟡 -1.8%) vs baseline: -0.9% Memory: ✅ 32.067MB (SLO: <34.000MB -5.7%) vs baseline: +4.7% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.435ms (SLO: <1.550ms -7.4%) vs baseline: +1.4% Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +5.1% ✅ 100-rate-metrics-100-timesTime: ✅ 2.245ms (SLO: <2.550ms 📉 -12.0%) vs baseline: -0.9% Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +5.1% ✅ flush-1-metricTime: ✅ 4.487µs (SLO: <20.000µs 📉 -77.6%) vs baseline: -1.5% Memory: ✅ 32.067MB (SLO: <34.000MB -5.7%) vs baseline: +4.4% ✅ flush-100-metricsTime: ✅ 174.690µs (SLO: <250.000µs 📉 -30.1%) vs baseline: -0.2% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +5.0% ✅ flush-1000-metricsTime: ✅ 2.148ms (SLO: <2.500ms 📉 -14.1%) vs baseline: +0.2% Memory: ✅ 32.893MB (SLO: <34.500MB -4.7%) vs baseline: +4.7%
|
Backport c1a6758 from #15036 to 3.17.
Reverts #15027
Fixes failing test and suitespec: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-py/-/pipelines/80160879