-
Notifications
You must be signed in to change notification settings - Fork 469
chore(logging): revert remove log correlation attributes from ddtrace loggers #15027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(logging): revert remove log correlation attributes from ddtrace loggers #15027
Conversation
…loggers …" This reverts commit b433817.
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 238 ± 2 ms. The average import time from base is: 240 ± 3 ms. The import time difference between this PR and base is: -2.5 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate revert-14979-munir/fix-logging-log-correlation-disabled (baeb37a) with baseline main (93aff64) 📈 Performance Regressions (1 suite)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 4.230µs (SLO: <10.000µs 📉 -57.7%) vs baseline: +0.6% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.9% ✅ ospathbasename_noaspectTime: ✅ 1.088µs (SLO: <10.000µs 📉 -89.1%) vs baseline: -0.3% Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +5.0% ✅ ospathjoin_aspectTime: ✅ 6.147µs (SLO: <10.000µs 📉 -38.5%) vs baseline: +0.5% Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +5.0% ✅ ospathjoin_noaspectTime: ✅ 2.306µs (SLO: <10.000µs 📉 -76.9%) vs baseline: +0.9% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.7% ✅ ospathnormcase_aspectTime: ✅ 3.520µs (SLO: <10.000µs 📉 -64.8%) vs baseline: +1.8% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.7% ✅ ospathnormcase_noaspectTime: ✅ 0.566µs (SLO: <10.000µs 📉 -94.3%) vs baseline: -0.4% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ ospathsplit_aspectTime: ✅ 4.817µs (SLO: <10.000µs 📉 -51.8%) vs baseline: +1.5% Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +4.9% ✅ ospathsplit_noaspectTime: ✅ 1.601µs (SLO: <10.000µs 📉 -84.0%) vs baseline: -0.1% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ ospathsplitdrive_aspectTime: ✅ 4.129µs (SLO: <10.000µs 📉 -58.7%) vs baseline: 📈 +11.6% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ ospathsplitdrive_noaspectTime: ✅ 0.699µs (SLO: <10.000µs 📉 -93.0%) vs baseline: +0.5% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ ospathsplitext_aspectTime: ✅ 4.558µs (SLO: <10.000µs 📉 -54.4%) vs baseline: +0.6% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.7% ✅ ospathsplitext_noaspectTime: ✅ 1.383µs (SLO: <10.000µs 📉 -86.2%) vs baseline: -0.3% Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +5.0% 🟡 Near SLO Breach (5 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.511ms (SLO: <22.300ms -8.0%) vs baseline: +0.2% Memory: ✅ 65.311MB (SLO: <67.000MB -2.5%) vs baseline: +4.9% ✅ exception-replay-enabledTime: ✅ 1.346ms (SLO: <1.450ms -7.2%) vs baseline: ~same Memory: ✅ 64.670MB (SLO: <67.000MB -3.5%) vs baseline: +4.7% ✅ iastTime: ✅ 20.502ms (SLO: <22.250ms -7.9%) vs baseline: ~same Memory: ✅ 65.233MB (SLO: <67.000MB -2.6%) vs baseline: +4.8% ✅ profilerTime: ✅ 15.266ms (SLO: <16.550ms -7.8%) vs baseline: +0.3% Memory: ✅ 54.067MB (SLO: <54.500MB 🟡 -0.8%) vs baseline: +4.7% ✅ resource-renamingTime: ✅ 20.594ms (SLO: <21.750ms -5.3%) vs baseline: +0.3% Memory: ✅ 65.252MB (SLO: <67.000MB -2.6%) vs baseline: +4.8% ✅ span-code-originTime: ✅ 25.419ms (SLO: <28.200ms -9.9%) vs baseline: -0.2% Memory: ✅ 67.486MB (SLO: <69.500MB -2.9%) vs baseline: +4.9% ✅ tracerTime: ✅ 20.529ms (SLO: <21.750ms -5.6%) vs baseline: ~same Memory: ✅ 65.271MB (SLO: <67.000MB -2.6%) vs baseline: +4.9% ✅ tracer-and-profilerTime: ✅ 22.145ms (SLO: <23.500ms -5.8%) vs baseline: +0.4% Memory: ✅ 66.668MB (SLO: <67.500MB 🟡 -1.2%) vs baseline: +4.8% ✅ tracer-dont-create-db-spansTime: ✅ 19.312ms (SLO: <21.500ms 📉 -10.2%) vs baseline: -0.1% Memory: ✅ 65.251MB (SLO: <66.000MB 🟡 -1.1%) vs baseline: +4.9% ✅ tracer-minimalTime: ✅ 16.650ms (SLO: <17.500ms -4.9%) vs baseline: -0.1% Memory: ✅ 65.253MB (SLO: <66.000MB 🟡 -1.1%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 20.473ms (SLO: <21.750ms -5.9%) vs baseline: +0.1% Memory: ✅ 71.310MB (SLO: <72.500MB 🟡 -1.6%) vs baseline: +4.7% ✅ tracer-no-cachesTime: ✅ 18.480ms (SLO: <19.650ms -6.0%) vs baseline: -0.3% Memory: ✅ 65.253MB (SLO: <67.000MB -2.6%) vs baseline: +4.8% ✅ tracer-no-databasesTime: ✅ 18.776ms (SLO: <20.100ms -6.6%) vs baseline: ~same Memory: ✅ 65.289MB (SLO: <67.000MB -2.6%) vs baseline: +4.9% ✅ tracer-no-middlewareTime: ✅ 20.212ms (SLO: <21.500ms -6.0%) vs baseline: ~same Memory: ✅ 65.328MB (SLO: <67.000MB -2.5%) vs baseline: +4.9% ✅ tracer-no-templatesTime: ✅ 20.373ms (SLO: <22.000ms -7.4%) vs baseline: ~same Memory: ✅ 65.229MB (SLO: <67.000MB -2.6%) vs baseline: +4.8% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.041ms (SLO: <19.850ms -9.1%) vs baseline: -0.3% Memory: ✅ 65.247MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ errortracking-enabled-userTime: ✅ 18.057ms (SLO: <19.400ms -6.9%) vs baseline: -0.2% Memory: ✅ 65.244MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ tracer-enabledTime: ✅ 18.030ms (SLO: <19.450ms -7.3%) vs baseline: -0.1% Memory: ✅ 65.204MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.8% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.593ms (SLO: <4.750ms -3.3%) vs baseline: +0.3% Memory: ✅ 61.971MB (SLO: <65.000MB -4.7%) vs baseline: +5.0% ✅ appsec-postTime: ✅ 6.630ms (SLO: <6.750ms 🟡 -1.8%) vs baseline: -0.1% Memory: ✅ 62.082MB (SLO: <65.000MB -4.5%) vs baseline: +5.0% ✅ appsec-telemetryTime: ✅ 4.592ms (SLO: <4.750ms -3.3%) vs baseline: ~same Memory: ✅ 61.892MB (SLO: <65.000MB -4.8%) vs baseline: +4.7% ✅ debuggerTime: ✅ 1.856ms (SLO: <2.000ms -7.2%) vs baseline: +0.2% Memory: ✅ 45.397MB (SLO: <47.000MB -3.4%) vs baseline: +4.7% ✅ iast-getTime: ✅ 1.858ms (SLO: <2.000ms -7.1%) vs baseline: ~same Memory: ✅ 42.467MB (SLO: <49.000MB 📉 -13.3%) vs baseline: +5.2% ✅ profilerTime: ✅ 1.909ms (SLO: <2.100ms -9.1%) vs baseline: ~same Memory: ✅ 46.537MB (SLO: <47.000MB 🟡 -1.0%) vs baseline: +4.4% ✅ resource-renamingTime: ✅ 3.373ms (SLO: <3.650ms -7.6%) vs baseline: ~same Memory: ✅ 52.278MB (SLO: <53.500MB -2.3%) vs baseline: +4.9% ✅ tracerTime: ✅ 3.362ms (SLO: <3.650ms -7.9%) vs baseline: +0.3% Memory: ✅ 52.160MB (SLO: <53.500MB -2.5%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 3.367ms (SLO: <3.650ms -7.7%) vs baseline: +0.2% Memory: ✅ 58.242MB (SLO: <60.000MB -2.9%) vs baseline: +4.6% 🟡 flasksqli - 6/6✅ appsec-enabledTime: ✅ 3.960ms (SLO: <4.200ms -5.7%) vs baseline: -0.7% Memory: ✅ 62.266MB (SLO: <66.000MB -5.7%) vs baseline: +5.0% ✅ iast-enabledTime: ✅ 2.457ms (SLO: <2.800ms 📉 -12.2%) vs baseline: +0.4% Memory: ✅ 58.884MB (SLO: <60.000MB 🟡 -1.9%) vs baseline: +4.6% ✅ tracer-enabledTime: ✅ 2.063ms (SLO: <2.250ms -8.3%) vs baseline: +0.3% Memory: ✅ 52.317MB (SLO: <54.500MB -4.0%) vs baseline: +4.9% 🟡 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 2.983µs (SLO: <20.000µs 📉 -85.1%) vs baseline: +0.4% Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +5.0% ✅ 1-count-metrics-100-timesTime: ✅ 199.703µs (SLO: <220.000µs -9.2%) vs baseline: +0.3% Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +4.9% ✅ 1-distribution-metric-1-timesTime: ✅ 3.582µs (SLO: <20.000µs 📉 -82.1%) vs baseline: +9.7% Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +4.7% ✅ 1-distribution-metrics-100-timesTime: ✅ 215.018µs (SLO: <220.000µs -2.3%) vs baseline: +1.2% Memory: ✅ 32.224MB (SLO: <34.000MB -5.2%) vs baseline: +5.1% ✅ 1-gauge-metric-1-timesTime: ✅ 2.180µs (SLO: <20.000µs 📉 -89.1%) vs baseline: ~same Memory: ✅ 32.244MB (SLO: <34.000MB -5.2%) vs baseline: +5.0% ✅ 1-gauge-metrics-100-timesTime: ✅ 138.115µs (SLO: <150.000µs -7.9%) vs baseline: +0.7% Memory: ✅ 32.204MB (SLO: <34.000MB -5.3%) vs baseline: +4.9% ✅ 1-rate-metric-1-timesTime: ✅ 3.105µs (SLO: <20.000µs 📉 -84.5%) vs baseline: -0.3% Memory: ✅ 32.204MB (SLO: <34.000MB -5.3%) vs baseline: +4.9% ✅ 1-rate-metrics-100-timesTime: ✅ 213.465µs (SLO: <250.000µs 📉 -14.6%) vs baseline: -0.2% Memory: ✅ 32.204MB (SLO: <34.000MB -5.3%) vs baseline: +5.0% ✅ 100-count-metrics-100-timesTime: ✅ 20.231ms (SLO: <22.000ms -8.0%) vs baseline: +0.4% Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +4.7% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.258ms (SLO: <2.300ms 🟡 -1.8%) vs baseline: +1.6% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.7% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.409ms (SLO: <1.550ms -9.1%) vs baseline: +0.7% Memory: ✅ 32.204MB (SLO: <34.000MB -5.3%) vs baseline: +4.8% ✅ 100-rate-metrics-100-timesTime: ✅ 2.256ms (SLO: <2.550ms 📉 -11.5%) vs baseline: +3.4% Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +4.8% ✅ flush-1-metricTime: ✅ 4.620µs (SLO: <20.000µs 📉 -76.9%) vs baseline: -0.2% Memory: ✅ 32.224MB (SLO: <34.000MB -5.2%) vs baseline: +5.0% ✅ flush-100-metricsTime: ✅ 174.976µs (SLO: <250.000µs 📉 -30.0%) vs baseline: -0.1% Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +4.7% ✅ flush-1000-metricsTime: ✅ 2.111ms (SLO: <2.500ms 📉 -15.6%) vs baseline: -0.3% Memory: ✅ 32.991MB (SLO: <34.500MB -4.4%) vs baseline: +5.0%
|
…s [Take 2] [backport 3.16] (#15043) Backport c1a6758 from #15036 to 3.16. Reverts #15027 Fixes failing test and suitespec: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-py/-/pipelines/80160879 Co-authored-by: Munir Abdinur <[email protected]>
…s [Take 2] [backport 3.17] (#15044) Backport c1a6758 from #15036 to 3.17. Reverts #15027 Fixes failing test and suitespec: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-py/-/pipelines/80160879 Co-authored-by: Munir Abdinur <[email protected]> Co-authored-by: Taegyun Kim <[email protected]>
Reverts #14979