Skip to content

Conversation

@juan-fernandez
Copy link
Collaborator

@juan-fernandez juan-fernandez commented Oct 31, 2025

What does this PR do?

Change threadHandler in the tinypool instrumentation to be able to support not only forks (the default in latest vitest versions) but also thread pool configuration.

Motivation

Fixes #6725

This for vitest@<4, as vitest@4 got rid of tinypool altogether: vitest-dev/vitest#8705 (https://github.com/vitest-dev/vitest/releases/tag/v4.0.0)

Plugin Checklist

  • Integration tests.

@github-actions
Copy link

github-actions bot commented Oct 31, 2025

Overall package size

Self size: 13.15 MB
Deduped: 117.18 MB
No deduping: 119.39 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 10.3.0 | 20.73 MB | 20.74 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.12.0 | 11.19 MB | 11.57 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.4 | 2.95 MB | 5.82 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @opentelemetry/resources | 1.9.1 | 306.54 kB | 1.74 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api-logs | 0.207.0 | 201.39 kB | 1.42 MB | | @opentelemetry/api | 1.9.0 | 1.22 MB | 1.22 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.15.0 | 127.66 kB | 856.24 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | @datadog/openfeature-node-server | 0.1.0-preview.12 | 95.11 kB | 401.68 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.2.1 | 163.06 kB | 163.06 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB | | escape-string-regexp | 5.0.0 | 3.66 kB | 3.66 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.75%. Comparing base (53670c5) to head (df017c9).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6809      +/-   ##
==========================================
- Coverage   84.05%   83.75%   -0.31%     
==========================================
  Files         506      505       -1     
  Lines       21260    21197      -63     
==========================================
- Hits        17871    17753     -118     
- Misses       3389     3444      +55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Oct 31, 2025

Benchmarks

Benchmark execution time: 2025-10-31 16:33:55

Comparing candidate commit df017c9 in PR branch juan-fernandez/fix-vitest-threads with baseline commit 53670c5 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1596 metrics, 74 unstable metrics.

assert.equal(metadata[testLevel][TEST_SESSION_NAME], 'my-test-session')
}
})
poolConfig.forEach((poolConfig) => {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the test almost did not change, I just added the content.meta[VITEST_POOL] assertions. It looks changed because two pool configs are run now

@juan-fernandez juan-fernandez marked this pull request as ready for review October 31, 2025 16:27
@juan-fernandez juan-fernandez requested review from a team as code owners October 31, 2025 16:27
@juan-fernandez juan-fernandez changed the title [test optimization] Support pool:"threads" in vitest [test optimization] Support pool:"threads" in vitest Nov 3, 2025
@juan-fernandez juan-fernandez merged commit 870560e into master Nov 3, 2025
763 checks passed
@juan-fernandez juan-fernandez deleted the juan-fernandez/fix-vitest-threads branch November 3, 2025 10:53
@dd-octo-sts dd-octo-sts bot mentioned this pull request Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Vitest integration - v5.72.0+ reports incompatible version when using vitest 3.2.4

3 participants