-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat!: rewrite pools without tinypool
#8705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+2,432
−3,088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
sheremet-va
reviewed
Oct 13, 2025
AriPerkkio
commented
Oct 14, 2025
6 tasks
f04fd9f to
3a0b0c2
Compare
4 tasks
PoolRuntime => PoolRunner (the runtime is the what is running, a bit confusing to mix them up. It is kind of a worker, but we provide a worker to it, so it doesn't make sense to mix them up, it's more of an orchestrator/runner on top of the worker) PoolRuntimeWorker => PoolWorker (we always had a runtime worker, but we also always had "maxWorkers" that referred to the previously named PoolRuntime, basically. I think the new name better describes its function). PoolRuntimeOptions => PoolOptions (we pass them down to both the runner and the worker, so let's have a shared name then)
AriPerkkio
commented
Oct 21, 2025
AriPerkkio
commented
Oct 21, 2025
Member
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI: Open
|
sheremet-va
approved these changes
Oct 21, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes Tinypool and adds new custom internal pool for Vitest only. Some previous thoughts I wrote ~2 months ago about this below.
Channel closederror as of recent version of Vitest #8201 (that one has no reproduction so can't say for sure 🤷)10partially breaks for Bun runtime #8650TODO:
vmMemoryworks. Worker should be recycled (e.g.pidchanges) after limit is reachedPlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.