Skip to content

Conversation

@juan-fernandez
Copy link
Collaborator

@juan-fernandez juan-fernandez commented May 11, 2023

What does this PR do?

Read git.properties file and parse git.commit.sha and git.repository_url.

Motivation

Continuation of #3118, this time allowing users to specify git metadata through a git.properties file.

@github-actions
Copy link

github-actions bot commented May 11, 2023

Overall package size

Self size: 4.12 MB
Deduped: 58.25 MB
No deduping: 58.29 MB

Dependency sizes

name version self size total size
@datadog/pprof 2.2.1 14.24 MB 15.12 MB
@datadog/native-iast-taint-tracking 1.4.1 14.85 MB 14.86 MB
@datadog/native-appsec 3.1.0 13.31 MB 13.32 MB
protobufjs 7.1.2 2.76 MB 6.55 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.3.8 88.2 kB 118.6 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.5 34.34 kB 38.81 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #3135 (069467d) into master (4e7da80) will increase coverage by 0.24%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3135      +/-   ##
==========================================
+ Coverage   87.15%   87.40%   +0.24%     
==========================================
  Files         316      327      +11     
  Lines       11585    11868     +283     
  Branches       33       33              
==========================================
+ Hits        10097    10373     +276     
- Misses       1488     1495       +7     
Impacted Files Coverage Δ
packages/dd-trace/src/config.js 98.94% <100.00%> (+0.04%) ⬆️
packages/dd-trace/src/git_properties.js 100.00% <100.00%> (ø)

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pr-commenter
Copy link

pr-commenter bot commented May 11, 2023

Benchmarks

Comparing candidate commit 069467d in PR branch juan-fernandez/attempt-to-read-git-properties with baseline commit 4e7da80 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 667 metrics, 41 unstable metrics.

@juan-fernandez juan-fernandez marked this pull request as ready for review May 11, 2023 14:54
@juan-fernandez juan-fernandez requested a review from a team as a code owner May 11, 2023 14:54
process.env.DD_GIT_COMMIT_SHA,
this.tags[GIT_COMMIT_SHA]
)
if (!this.repositoryUrl || !this.commitSHA) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker for this PR, but this is starting to be a lot of code in config.js which should probably be moved out at some point.

@rochdev rochdev merged commit 7c09873 into master May 11, 2023
rochdev pushed a commit that referenced this pull request May 11, 2023
* read git.properties

* more and better tests

* fix tests
rochdev pushed a commit that referenced this pull request May 11, 2023
* read git.properties

* more and better tests

* fix tests
@juan-fernandez juan-fernandez deleted the juan-fernandez/attempt-to-read-git-properties branch May 12, 2023 07:22
rochdev pushed a commit that referenced this pull request May 12, 2023
* read git.properties

* more and better tests

* fix tests
rochdev pushed a commit that referenced this pull request May 12, 2023
* read git.properties

* more and better tests

* fix tests
thedavl pushed a commit that referenced this pull request May 30, 2023
* read git.properties

* more and better tests

* fix tests
@khanayan123 khanayan123 mentioned this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants