-
Notifications
You must be signed in to change notification settings - Fork 357
SCI Embedding - read git.properties file
#3135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCI Embedding - read git.properties file
#3135
Conversation
Overall package sizeSelf size: 4.12 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #3135 +/- ##
==========================================
+ Coverage 87.15% 87.40% +0.24%
==========================================
Files 316 327 +11
Lines 11585 11868 +283
Branches 33 33
==========================================
+ Hits 10097 10373 +276
- Misses 1488 1495 +7
... and 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| process.env.DD_GIT_COMMIT_SHA, | ||
| this.tags[GIT_COMMIT_SHA] | ||
| ) | ||
| if (!this.repositoryUrl || !this.commitSHA) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a blocker for this PR, but this is starting to be a lot of code in config.js which should probably be moved out at some point.
* read git.properties * more and better tests * fix tests
* read git.properties * more and better tests * fix tests
* read git.properties * more and better tests * fix tests
* read git.properties * more and better tests * fix tests
* read git.properties * more and better tests * fix tests
What does this PR do?
Read
git.propertiesfile and parsegit.commit.shaandgit.repository_url.Motivation
Continuation of #3118, this time allowing users to specify git metadata through a
git.propertiesfile.