SCI Embedding of git metadata #3118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overall package sizeSelf size: 4.11 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
juan-fernandez
commented
May 8, 2023
Codecov Report
@@ Coverage Diff @@
## master #3118 +/- ##
==========================================
- Coverage 87.33% 84.81% -2.53%
==========================================
Files 325 275 -50
Lines 11830 10587 -1243
Branches 33 33
==========================================
- Hits 10332 8979 -1353
- Misses 1498 1608 +110
... and 63 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
juan-fernandez
changed the title
juan-fernandez
changed the title
rochdev
requested changes
May 9, 2023
| } | ||
| } | ||
|
|
||
| addRepositoryMetadata (spans) { |
Member
There was a problem hiding this comment.
This seems like something the formatter should do since it's responsible for knowing how to use the trace from the span. It's also already handling similar other tags.
| const tagger = require('./tagger') | ||
| const { isTrue, isFalse } = require('./util') | ||
| const uuid = require('crypto-randomuuid') | ||
| const { GIT_REPOSITORY_URL, GIT_COMMIT_SHA } = require('./plugins/util/tags') |
Member
There was a problem hiding this comment.
It looks like these are expected to be set by users? If that's the case they should probably be moved to ext/tags.
Collaborator
Author
There was a problem hiding this comment.
yeah that makes sense. I'll do this in another PR though, because there are multiple files to change and I don't want to make this harder to review
packages/dd-trace/src/config.js
Outdated
| this.isGitUploadEnabled = this.isCiVisibility && | ||
| (this.isIntelligentTestRunnerEnabled && !isFalse(DD_CIVISIBILITY_GIT_UPLOAD_ENABLED)) | ||
|
|
||
| this.isTraceGitMetadataEnabled = isTrue(DD_TRACE_GIT_METADATA_ENABLED) |
Member
There was a problem hiding this comment.
Let's keep it consistent, so gitMetadataEnabled.
juan-fernandez
force-pushed
the
juan-fernandez/sci-embedding
branch
from
03302f1 to
8201501
Compare
juan-fernandez
commented
May 10, 2023
|
|
||
| tagGitMetadata (spanContext) { | ||
| if (this._config.gitMetadataEnabled) { | ||
| spanContext._trace.tags[SCI_COMMIT_SHA] = this._config.commitSHA |
Collaborator
Author
There was a problem hiding this comment.
these trace tags are only added to the local root in format.js via extractChunkTags
rochdev
approved these changes
May 10, 2023
rochdev
pushed a commit
that referenced
this pull request
May 11, 2023
rochdev
pushed a commit
that referenced
this pull request
May 11, 2023
rochdev
pushed a commit
that referenced
this pull request
May 12, 2023
rochdev
pushed a commit
that referenced
this pull request
May 12, 2023
thedavl
pushed a commit
that referenced
this pull request
May 30, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
DD_TRACE_GIT_METADATA_ENABLEDconfig env var, with a default oftrueDD_GIT_REPOSITORY_URLandDD_GIT_COMMIT_SHAenv vars.git.repository_urlandgit.commit.shafromDD_TAGS.Motivation
Allow some products to provide source code related features.
Additional Notes
Unrelated fix: warp
esbuild.spec.jstest in adescribe.