Skip to content

Remove unused TestEventsHandler methods #8674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2025
Merged

Remove unused TestEventsHandler methods #8674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2497492
Remove unused TestEventsHandler methods
nikita-tkachenko-datadog Apr 7, 2025
3c20927
Merge branch 'master' into nikita-tkachenko/remove-unused-test-ev-han…
nikita-tkachenko-datadog Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ...nt-ci-visibility/src/main/java/datadog/trace/civisibility/domain/TestFrameworkModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@ TestSuiteImpl testSuiteStart(
*/
boolean isNew(@Nonnull TestIdentifier test);

boolean isFlaky(@Nonnull TestIdentifier test);

boolean isModified(@Nonnull TestSourceData testSourceData);

boolean isQuarantined(TestIdentifier test);
Expand Down
5 changes: 0 additions & 5 deletions ...sibility/src/main/java/datadog/trace/civisibility/domain/buildsystem/ProxyTestModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,11 +98,6 @@ public boolean isNew(@Nonnull TestIdentifier test) {
return executionStrategy.isNew(test);
}

@Override
public boolean isFlaky(@Nonnull TestIdentifier test) {
return executionStrategy.isFlaky(test);
}

@Override
public boolean isModified(@Nonnull TestSourceData testSourceData) {
return executionStrategy.isModified(testSourceData);
Expand Down
5 changes: 0 additions & 5 deletions ...sibility/src/main/java/datadog/trace/civisibility/domain/headless/HeadlessTestModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,6 @@ public boolean isNew(@Nonnull TestIdentifier test) {
return executionStrategy.isNew(test);
}

@Override
public boolean isFlaky(@Nonnull TestIdentifier test) {
return executionStrategy.isFlaky(test);
}

@Override
public boolean isModified(@Nonnull TestSourceData testSourceData) {
return executionStrategy.isModified(testSourceData);
Expand Down
10 changes: 0 additions & 10 deletions ...-ci-visibility/src/main/java/datadog/trace/civisibility/events/NoOpTestEventsHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,16 +105,6 @@ public TestExecutionPolicy executionPolicy(
return Regular.INSTANCE;
}

@Override
public boolean isNew(@Nonnull TestIdentifier test) {
return false;
}

@Override
public boolean isFlaky(@Nonnull TestIdentifier test) {
return false;
}

@Override
public int executionPriority(
@Nullable TestIdentifier test, @Nonnull TestSourceData testSourceData) {
Expand Down
10 changes: 0 additions & 10 deletions ...-ci-visibility/src/main/java/datadog/trace/civisibility/events/TestEventsHandlerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,16 +305,6 @@ public int executionPriority(@Nullable TestIdentifier test, @Nonnull TestSourceD
return testModule.executionPriority(test, testSource);
}

@Override
public boolean isNew(@Nonnull TestIdentifier test) {
return testModule.isNew(test);
}

@Override
public boolean isFlaky(@Nonnull TestIdentifier test) {
return testModule.isFlaky(test);
}

@Nullable
@Override
public SkipReason skipReason(TestIdentifier test) {
Expand Down
2 changes: 1 addition & 1 deletion .../agent-ci-visibility/src/main/java/datadog/trace/civisibility/test/ExecutionStrategy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public boolean isNew(@Nonnull TestIdentifier test) {
&& !executionSettings.isKnown(test.toFQN());
}

public boolean isFlaky(@Nonnull TestIdentifier test) {
private boolean isFlaky(@Nonnull TestIdentifier test) {
return executionSettings.isFlaky(test.toFQN());
}

Expand Down
4 changes: 0 additions & 4 deletions internal-api/src/main/java/datadog/trace/api/civisibility/events/TestEventsHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,10 +107,6 @@ TestExecutionPolicy executionPolicy(
@Nullable
SkipReason skipReason(TestIdentifier test);

boolean isNew(@Nonnull TestIdentifier test);

boolean isFlaky(@Nonnull TestIdentifier test);

@Override
void close();

Expand Down