Skip to content

Conversation

@nikita-tkachenko-datadog
Copy link
Contributor

@nikita-tkachenko-datadog nikita-tkachenko-datadog commented Apr 7, 2025

What Does This Do

Code clean up: removing some unused methods from CI Visibility codebase

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@pr-commenter
Copy link

pr-commenter bot commented Apr 7, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/remove-unused-test-ev-handler-methods
git_commit_date 1744128769 1744135589
git_commit_sha 30c99de 3c20927
release_version 1.48.0-SNAPSHOT~30c99de434 1.48.0-SNAPSHOT~3c209275b0
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1744138419 1744138419
ci_job_id 887097193 887097193
ci_pipeline_id 61487461 61487461
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-ahs87n8s-project-304-concurrent-1-xm4or0og 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-ahs87n8s-project-304-concurrent-1-xm4or0og 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 66 metrics, 5 unstable metrics.

Startup time reports for insecure-bank
gantt
    title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~3c209275b0, baseline=1.48.0-SNAPSHOT~30c99de434

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.058 s) : 0, 1057668
Total [baseline] (8.677 s) : 0, 8677294
Agent [candidate] (1.057 s) : 0, 1056647
Total [candidate] (8.68 s) : 0, 8679969
section iast
Agent [baseline] (1.194 s) : 0, 1193528
Total [baseline] (9.256 s) : 0, 9255831
Agent [candidate] (1.192 s) : 0, 1191915
Total [candidate] (9.295 s) : 0, 9294804
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.202 s) : 0, 1202273
Total [baseline] (9.268 s) : 0, 9268182
Agent [candidate] (1.194 s) : 0, 1194397
Total [candidate] (9.264 s) : 0, 9263742
section iast_TELEMETRY_OFF
Agent [baseline] (1.19 s) : 0, 1190186
Total [baseline] (9.315 s) : 0, 9315159
Agent [candidate] (1.187 s) : 0, 1186575
Total [candidate] (9.296 s) : 0, 9296329
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.058 s -
Agent iast 1.194 s 135.86 ms (12.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.202 s 144.605 ms (13.7%)
Agent iast_TELEMETRY_OFF 1.19 s 132.518 ms (12.5%)
Total tracing 8.677 s -
Total iast 9.256 s 578.537 ms (6.7%)
Total iast_HARDCODED_SECRET_DISABLED 9.268 s 590.889 ms (6.8%)
Total iast_TELEMETRY_OFF 9.315 s 637.865 ms (7.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.057 s -
Agent iast 1.192 s 135.268 ms (12.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.194 s 137.75 ms (13.0%)
Agent iast_TELEMETRY_OFF 1.187 s 129.927 ms (12.3%)
Total tracing 8.68 s -
Total iast 9.295 s 614.834 ms (7.1%)
Total iast_HARDCODED_SECRET_DISABLED 9.264 s 583.773 ms (6.7%)
Total iast_TELEMETRY_OFF 9.296 s 616.36 ms (7.1%)
gantt
    title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~3c209275b0, baseline=1.48.0-SNAPSHOT~30c99de434

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (723.125 ms) : 0, 723125
BytebuddyAgent [candidate] (721.982 ms) : 0, 721982
GlobalTracer [baseline] (240.09 ms) : 0, 240090
GlobalTracer [candidate] (240.231 ms) : 0, 240231
AppSec [baseline] (54.941 ms) : 0, 54941
AppSec [candidate] (54.367 ms) : 0, 54367
Debugger [baseline] (4.462 ms) : 0, 4462
Debugger [candidate] (4.411 ms) : 0, 4411
Remote Config [baseline] (716.798 µs) : 0, 717
Remote Config [candidate] (712.86 µs) : 0, 713
Telemetry [baseline] (13.512 ms) : 0, 13512
Telemetry [candidate] (14.116 ms) : 0, 14116
section iast
BytebuddyAgent [baseline] (848.976 ms) : 0, 848976
BytebuddyAgent [candidate] (847.445 ms) : 0, 847445
GlobalTracer [baseline] (230.999 ms) : 0, 230999
GlobalTracer [candidate] (231.419 ms) : 0, 231419
AppSec [baseline] (56.142 ms) : 0, 56142
AppSec [candidate] (55.048 ms) : 0, 55048
Debugger [baseline] (4.175 ms) : 0, 4175
Debugger [candidate] (4.147 ms) : 0, 4147
Remote Config [baseline] (605.561 µs) : 0, 606
Remote Config [candidate] (601.55 µs) : 0, 602
Telemetry [baseline] (8.853 ms) : 0, 8853
Telemetry [candidate] (8.756 ms) : 0, 8756
IAST [baseline] (22.864 ms) : 0, 22864
IAST [candidate] (23.574 ms) : 0, 23574
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (855.514 ms) : 0, 855514
BytebuddyAgent [candidate] (849.032 ms) : 0, 849032
GlobalTracer [baseline] (232.839 ms) : 0, 232839
GlobalTracer [candidate] (231.573 ms) : 0, 231573
AppSec [baseline] (56.029 ms) : 0, 56029
AppSec [candidate] (56.329 ms) : 0, 56329
Debugger [baseline] (4.152 ms) : 0, 4152
Debugger [candidate] (4.101 ms) : 0, 4101
Remote Config [baseline] (597.467 µs) : 0, 597
Remote Config [candidate] (594.22 µs) : 0, 594
Telemetry [baseline] (8.847 ms) : 0, 8847
Telemetry [candidate] (8.776 ms) : 0, 8776
IAST [baseline] (23.231 ms) : 0, 23231
IAST [candidate] (23.034 ms) : 0, 23034
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (845.25 ms) : 0, 845250
BytebuddyAgent [candidate] (844.029 ms) : 0, 844029
GlobalTracer [baseline] (231.547 ms) : 0, 231547
GlobalTracer [candidate] (230.307 ms) : 0, 230307
AppSec [baseline] (56.651 ms) : 0, 56651
AppSec [candidate] (55.86 ms) : 0, 55860
Debugger [baseline] (4.187 ms) : 0, 4187
Debugger [candidate] (4.131 ms) : 0, 4131
Remote Config [baseline] (599.516 µs) : 0, 600
Remote Config [candidate] (593.922 µs) : 0, 594
Telemetry [baseline] (8.594 ms) : 0, 8594
Telemetry [candidate] (8.609 ms) : 0, 8609
IAST [baseline] (22.456 ms) : 0, 22456
IAST [candidate] (22.185 ms) : 0, 22185
Loading
Startup time reports for petclinic
gantt
    title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~3c209275b0, baseline=1.48.0-SNAPSHOT~30c99de434

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1060178
Total [baseline] (10.492 s) : 0, 10491632
Agent [candidate] (1.06 s) : 0, 1059828
Total [candidate] (10.563 s) : 0, 10563137
section appsec
Agent [baseline] (1.203 s) : 0, 1203443
Total [baseline] (10.781 s) : 0, 10780574
Agent [candidate] (1.198 s) : 0, 1198264
Total [candidate] (10.748 s) : 0, 10747559
section iast
Agent [baseline] (1.185 s) : 0, 1185237
Total [baseline] (11.03 s) : 0, 11030342
Agent [candidate] (1.182 s) : 0, 1182383
Total [candidate] (11.022 s) : 0, 11021876
section profiling
Agent [baseline] (1.293 s) : 0, 1292781
Total [baseline] (10.916 s) : 0, 10915970
Agent [candidate] (1.296 s) : 0, 1295714
Total [candidate] (10.896 s) : 0, 10895896
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.06 s -
Agent appsec 1.203 s 143.265 ms (13.5%)
Agent iast 1.185 s 125.058 ms (11.8%)
Agent profiling 1.293 s 232.603 ms (21.9%)
Total tracing 10.492 s -
Total appsec 10.781 s 288.942 ms (2.8%)
Total iast 11.03 s 538.71 ms (5.1%)
Total profiling 10.916 s 424.338 ms (4.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.06 s -
Agent appsec 1.198 s 138.435 ms (13.1%)
Agent iast 1.182 s 122.554 ms (11.6%)
Agent profiling 1.296 s 235.886 ms (22.3%)
Total tracing 10.563 s -
Total appsec 10.748 s 184.422 ms (1.7%)
Total iast 11.022 s 458.74 ms (4.3%)
Total profiling 10.896 s 332.76 ms (3.2%)
gantt
    title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~3c209275b0, baseline=1.48.0-SNAPSHOT~30c99de434

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (723.466 ms) : 0, 723466
BytebuddyAgent [candidate] (722.639 ms) : 0, 722639
GlobalTracer [baseline] (240.441 ms) : 0, 240441
GlobalTracer [candidate] (240.149 ms) : 0, 240149
AppSec [baseline] (54.484 ms) : 0, 54484
AppSec [candidate] (54.496 ms) : 0, 54496
Debugger [baseline] (4.437 ms) : 0, 4437
Debugger [candidate] (4.444 ms) : 0, 4444
Remote Config [baseline] (688.307 µs) : 0, 688
Remote Config [candidate] (707.791 µs) : 0, 708
Telemetry [baseline] (15.725 ms) : 0, 15725
Telemetry [candidate] (16.433 ms) : 0, 16433
section appsec
BytebuddyAgent [baseline] (744.302 ms) : 0, 744302
BytebuddyAgent [candidate] (741.017 ms) : 0, 741017
GlobalTracer [baseline] (237.232 ms) : 0, 237232
GlobalTracer [candidate] (236.332 ms) : 0, 236332
IAST [baseline] (21.549 ms) : 0, 21549
IAST [candidate] (21.38 ms) : 0, 21380
AppSec [baseline] (176.928 ms) : 0, 176928
AppSec [candidate] (176.245 ms) : 0, 176245
Debugger [baseline] (4.282 ms) : 0, 4282
Debugger [candidate] (4.242 ms) : 0, 4242
Remote Config [baseline] (647.993 µs) : 0, 648
Remote Config [candidate] (639.254 µs) : 0, 639
Telemetry [baseline] (8.337 ms) : 0, 8337
Telemetry [candidate] (8.246 ms) : 0, 8246
section iast
BytebuddyAgent [baseline] (841.954 ms) : 0, 841954
BytebuddyAgent [candidate] (840.321 ms) : 0, 840321
GlobalTracer [baseline] (230.3 ms) : 0, 230300
GlobalTracer [candidate] (229.42 ms) : 0, 229420
IAST [baseline] (22.645 ms) : 0, 22645
IAST [candidate] (22.637 ms) : 0, 22637
AppSec [baseline] (56.136 ms) : 0, 56136
AppSec [candidate] (55.753 ms) : 0, 55753
Debugger [baseline] (4.099 ms) : 0, 4099
Debugger [candidate] (4.111 ms) : 0, 4111
Remote Config [baseline] (594.398 µs) : 0, 594
Remote Config [candidate] (592.042 µs) : 0, 592
Telemetry [baseline] (8.711 ms) : 0, 8711
Telemetry [candidate] (8.751 ms) : 0, 8751
section profiling
BytebuddyAgent [baseline] (713.622 ms) : 0, 713622
BytebuddyAgent [candidate] (715.506 ms) : 0, 715506
GlobalTracer [baseline] (360.332 ms) : 0, 360332
GlobalTracer [candidate] (361.09 ms) : 0, 361090
AppSec [baseline] (54.19 ms) : 0, 54190
AppSec [candidate] (53.252 ms) : 0, 53252
Debugger [baseline] (4.315 ms) : 0, 4315
Debugger [candidate] (4.29 ms) : 0, 4290
Remote Config [baseline] (763.623 µs) : 0, 764
Remote Config [candidate] (714.79 µs) : 0, 715
Telemetry [baseline] (9.005 ms) : 0, 9005
Telemetry [candidate] (8.968 ms) : 0, 8968
ProfilingAgent [baseline] (102.445 ms) : 0, 102445
ProfilingAgent [candidate] (103.811 ms) : 0, 103811
Profiling [baseline] (102.47 ms) : 0, 102470
Profiling [candidate] (103.836 ms) : 0, 103836
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-04-08T18:23:49 2025-04-08T18:31:35
git_branch master nikita-tkachenko/remove-unused-test-ev-handler-methods
git_commit_date 1744128769 1744135589
git_commit_sha 30c99de 3c20927
release_version 1.48.0-SNAPSHOT~30c99de434 1.48.0-SNAPSHOT~3c209275b0
start_time 2025-04-08T18:23:35 2025-04-08T18:31:21
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1744137495 1744137495
ci_job_id 887097194 887097194
ci_pipeline_id 61487461 61487461
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-robvewte-project-304-concurrent-0-e5gos7uh 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-robvewte-project-304-concurrent-0-e5gos7uh 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 17 unstable metrics.

Request duration reports for insecure-bank
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~3c209275b0, baseline=1.48.0-SNAPSHOT~30c99de434
    dateFormat X
    axisFormat %s
section baseline
no_agent (381.496 µs) : 361, 402
.   : milestone, 381,
iast (518.006 µs) : 496, 540
.   : milestone, 518,
iast_FULL (735.345 µs) : 713, 757
.   : milestone, 735,
iast_GLOBAL (571.3 µs) : 548, 594
.   : milestone, 571,
iast_HARDCODED_SECRET_DISABLED (515.872 µs) : 494, 538
.   : milestone, 516,
iast_INACTIVE (465.968 µs) : 444, 488
.   : milestone, 466,
iast_TELEMETRY_OFF (501.523 µs) : 480, 523
.   : milestone, 502,
tracing (454.728 µs) : 434, 476
.   : milestone, 455,
section candidate
no_agent (387.311 µs) : 368, 407
.   : milestone, 387,
iast (515.316 µs) : 494, 537
.   : milestone, 515,
iast_FULL (730.457 µs) : 709, 752
.   : milestone, 730,
iast_GLOBAL (556.928 µs) : 535, 579
.   : milestone, 557,
iast_HARDCODED_SECRET_DISABLED (519.539 µs) : 498, 541
.   : milestone, 520,
iast_INACTIVE (469.422 µs) : 448, 491
.   : milestone, 469,
iast_TELEMETRY_OFF (504.998 µs) : 483, 527
.   : milestone, 505,
tracing (458.71 µs) : 438, 480
.   : milestone, 459,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 381.496 µs [361.391 µs, 401.6 µs] -
iast 518.006 µs [495.911 µs, 540.101 µs] 136.511 µs (35.8%)
iast_FULL 735.345 µs [713.459 µs, 757.231 µs] 353.849 µs (92.8%)
iast_GLOBAL 571.3 µs [548.214 µs, 594.386 µs] 189.804 µs (49.8%)
iast_HARDCODED_SECRET_DISABLED 515.872 µs [493.994 µs, 537.749 µs] 134.376 µs (35.2%)
iast_INACTIVE 465.968 µs [444.175 µs, 487.762 µs] 84.473 µs (22.1%)
iast_TELEMETRY_OFF 501.523 µs [479.796 µs, 523.251 µs] 120.028 µs (31.5%)
tracing 454.728 µs [433.94 µs, 475.517 µs] 73.232 µs (19.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 387.311 µs [367.67 µs, 406.952 µs] -
iast 515.316 µs [493.522 µs, 537.11 µs] 128.005 µs (33.0%)
iast_FULL 730.457 µs [708.534 µs, 752.379 µs] 343.146 µs (88.6%)
iast_GLOBAL 556.928 µs [535.255 µs, 578.602 µs] 169.618 µs (43.8%)
iast_HARDCODED_SECRET_DISABLED 519.539 µs [497.606 µs, 541.473 µs] 132.229 µs (34.1%)
iast_INACTIVE 469.422 µs [447.852 µs, 490.992 µs] 82.111 µs (21.2%)
iast_TELEMETRY_OFF 504.998 µs [482.766 µs, 527.229 µs] 117.687 µs (30.4%)
tracing 458.71 µs [437.77 µs, 479.651 µs] 71.399 µs (18.4%)
Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~3c209275b0, baseline=1.48.0-SNAPSHOT~30c99de434
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.36 ms) : 1340, 1379
.   : milestone, 1360,
appsec (1.733 ms) : 1710, 1757
.   : milestone, 1733,
appsec_no_iast (1.755 ms) : 1731, 1779
.   : milestone, 1755,
code_origins (1.675 ms) : 1648, 1702
.   : milestone, 1675,
iast (1.527 ms) : 1501, 1552
.   : milestone, 1527,
profiling (1.547 ms) : 1521, 1572
.   : milestone, 1547,
tracing (1.51 ms) : 1486, 1534
.   : milestone, 1510,
section candidate
no_agent (1.36 ms) : 1340, 1379
.   : milestone, 1360,
appsec (1.733 ms) : 1709, 1757
.   : milestone, 1733,
appsec_no_iast (1.761 ms) : 1738, 1784
.   : milestone, 1761,
code_origins (1.697 ms) : 1671, 1723
.   : milestone, 1697,
iast (1.521 ms) : 1496, 1546
.   : milestone, 1521,
profiling (1.594 ms) : 1570, 1619
.   : milestone, 1594,
tracing (1.492 ms) : 1467, 1517
.   : milestone, 1492,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.36 ms [1.34 ms, 1.379 ms] -
appsec 1.733 ms [1.71 ms, 1.757 ms] 373.533 µs (27.5%)
appsec_no_iast 1.755 ms [1.731 ms, 1.779 ms] 394.982 µs (29.0%)
code_origins 1.675 ms [1.648 ms, 1.702 ms] 315.193 µs (23.2%)
iast 1.527 ms [1.501 ms, 1.552 ms] 166.915 µs (12.3%)
profiling 1.547 ms [1.521 ms, 1.572 ms] 186.868 µs (13.7%)
tracing 1.51 ms [1.486 ms, 1.534 ms] 149.829 µs (11.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.36 ms [1.34 ms, 1.379 ms] -
appsec 1.733 ms [1.709 ms, 1.757 ms] 373.292 µs (27.5%)
appsec_no_iast 1.761 ms [1.738 ms, 1.784 ms] 400.998 µs (29.5%)
code_origins 1.697 ms [1.671 ms, 1.723 ms] 337.224 µs (24.8%)
iast 1.521 ms [1.496 ms, 1.546 ms] 161.051 µs (11.8%)
profiling 1.594 ms [1.57 ms, 1.619 ms] 234.383 µs (17.2%)
tracing 1.492 ms [1.467 ms, 1.517 ms] 131.807 µs (9.7%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/remove-unused-test-ev-handler-methods
git_commit_date 1744128769 1744135589
git_commit_sha 30c99de 3c20927
release_version 1.48.0-SNAPSHOT~30c99de434 1.48.0-SNAPSHOT~3c209275b0
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1744137995 1744137995
ci_job_id 887097195 887097195
ci_pipeline_id 61487461 61487461
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-ahs87n8s-project-304-concurrent-2-oyovuv7c 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-ahs87n8s-project-304-concurrent-2-oyovuv7c 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~3c209275b0, baseline=1.48.0-SNAPSHOT~30c99de434
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.477 ms) : 1465, 1488
.   : milestone, 1477,
appsec (2.379 ms) : 2332, 2427
.   : milestone, 2379,
iast (2.159 ms) : 2099, 2218
.   : milestone, 2159,
iast_GLOBAL (2.205 ms) : 2145, 2265
.   : milestone, 2205,
profiling (2.026 ms) : 1978, 2074
.   : milestone, 2026,
tracing (1.991 ms) : 1945, 2037
.   : milestone, 1991,
section candidate
no_agent (1.473 ms) : 1461, 1484
.   : milestone, 1473,
appsec (2.377 ms) : 2330, 2424
.   : milestone, 2377,
iast (2.162 ms) : 2102, 2221
.   : milestone, 2162,
iast_GLOBAL (2.201 ms) : 2141, 2260
.   : milestone, 2201,
profiling (2.019 ms) : 1971, 2066
.   : milestone, 2019,
tracing (1.986 ms) : 1940, 2032
.   : milestone, 1986,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.477 ms [1.465 ms, 1.488 ms] -
appsec 2.379 ms [2.332 ms, 2.427 ms] 902.966 µs (61.2%)
iast 2.159 ms [2.099 ms, 2.218 ms] 682.189 µs (46.2%)
iast_GLOBAL 2.205 ms [2.145 ms, 2.265 ms] 728.604 µs (49.3%)
profiling 2.026 ms [1.978 ms, 2.074 ms] 549.231 µs (37.2%)
tracing 1.991 ms [1.945 ms, 2.037 ms] 514.536 µs (34.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.473 ms [1.461 ms, 1.484 ms] -
appsec 2.377 ms [2.33 ms, 2.424 ms] 904.342 µs (61.4%)
iast 2.162 ms [2.102 ms, 2.221 ms] 688.863 µs (46.8%)
iast_GLOBAL 2.201 ms [2.141 ms, 2.26 ms] 727.883 µs (49.4%)
profiling 2.019 ms [1.971 ms, 2.066 ms] 545.72 µs (37.1%)
tracing 1.986 ms [1.94 ms, 2.032 ms] 513.3 µs (34.9%)
Execution time for biojava
gantt
    title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~3c209275b0, baseline=1.48.0-SNAPSHOT~30c99de434
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.42 s) : 15420000, 15420000
.   : milestone, 15420000,
appsec (14.79 s) : 14790000, 14790000
.   : milestone, 14790000,
iast (18.711 s) : 18711000, 18711000
.   : milestone, 18711000,
iast_GLOBAL (18.451 s) : 18451000, 18451000
.   : milestone, 18451000,
profiling (15.47 s) : 15470000, 15470000
.   : milestone, 15470000,
tracing (14.961 s) : 14961000, 14961000
.   : milestone, 14961000,
section candidate
no_agent (15.659 s) : 15659000, 15659000
.   : milestone, 15659000,
appsec (14.988 s) : 14988000, 14988000
.   : milestone, 14988000,
iast (18.661 s) : 18661000, 18661000
.   : milestone, 18661000,
iast_GLOBAL (18.221 s) : 18221000, 18221000
.   : milestone, 18221000,
profiling (15.017 s) : 15017000, 15017000
.   : milestone, 15017000,
tracing (14.923 s) : 14923000, 14923000
.   : milestone, 14923000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.42 s [15.42 s, 15.42 s] -
appsec 14.79 s [14.79 s, 14.79 s] -630.0 ms (-4.1%)
iast 18.711 s [18.711 s, 18.711 s] 3.291 s (21.3%)
iast_GLOBAL 18.451 s [18.451 s, 18.451 s] 3.031 s (19.7%)
profiling 15.47 s [15.47 s, 15.47 s] 50.0 ms (0.3%)
tracing 14.961 s [14.961 s, 14.961 s] -459.0 ms (-3.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.659 s [15.659 s, 15.659 s] -
appsec 14.988 s [14.988 s, 14.988 s] -671.0 ms (-4.3%)
iast 18.661 s [18.661 s, 18.661 s] 3.002 s (19.2%)
iast_GLOBAL 18.221 s [18.221 s, 18.221 s] 2.562 s (16.4%)
profiling 15.017 s [15.017 s, 15.017 s] -642.0 ms (-4.1%)
tracing 14.923 s [14.923 s, 14.923 s] -736.0 ms (-4.7%)

@nikita-tkachenko-datadog nikita-tkachenko-datadog marked this pull request as ready for review April 8, 2025 11:30
@nikita-tkachenko-datadog nikita-tkachenko-datadog requested a review from a team as a code owner April 8, 2025 11:30
@nikita-tkachenko-datadog nikita-tkachenko-datadog merged commit 03b9371 into master Apr 9, 2025
252 checks passed
@nikita-tkachenko-datadog nikita-tkachenko-datadog deleted the nikita-tkachenko/remove-unused-test-ev-handler-methods branch April 9, 2025 15:36
@github-actions github-actions bot added this to the 1.49.0 milestone Apr 9, 2025
svc-squareup-copybara pushed a commit to cashapp/misk that referenced this pull request May 7, 2025
| Package | Type | Package file | Manager | Update | Change |
|---|---|---|---|---|---|
|
[com.google.cloud:google-cloud-logging](https://github.com/googleapis/java-logging)
| dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`3.22.2` -> `3.22.3` |
|
[com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore)
| dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.28.0` -> `2.28.1` |
| [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java)
| dependencies | misk/gradle/libs.versions.toml | gradle | minor |
`1.48.2` -> `1.49.0` |
| [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.36` -> `2.31.37` |
| [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.36` -> `2.31.37` |
|
[software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava)
| dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.36` -> `2.31.37` |
| [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.36` -> `2.31.37` |
| [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.36` -> `2.31.37` |
| [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.36` -> `2.31.37` |
| [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.36` -> `2.31.37` |

---

### Release Notes

<details>
<summary>googleapis/java-logging
(com.google.cloud:google-cloud-logging)</summary>

###
[`v3.22.3`](https://github.com/googleapis/java-logging/blob/HEAD/CHANGELOG.md#3223-2025-05-06)

##### Bug Fixes

- **deps:** Update the Java code generator (gapic-generator-java) to
2.56.3
([844f4fa](googleapis/java-logging@844f4fa))

##### Dependencies

- Update dependency com.google.cloud:sdk-platform-java-config to v3.46.3
([#&#8203;1801](googleapis/java-logging#1801))
([d7aa7bc](googleapis/java-logging@d7aa7bc))
- Update dependency com.google.cloud:sdk-platform-java-config to v3.47.0
([#&#8203;1803](googleapis/java-logging#1803))
([5967ffe](googleapis/java-logging@5967ffe))
- Update googleapis/sdk-platform-java action to v2.57.0
([#&#8203;1804](googleapis/java-logging#1804))
([e9a27ec](googleapis/java-logging@e9a27ec))

</details>

<details>
<summary>googleapis/java-datastore
(com.google.cloud:google-cloud-datastore)</summary>

###
[`v2.28.1`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2281-2025-05-06)

##### Dependencies

- Update dependency com.google.cloud:sdk-platform-java-config to v3.47.0
([#&#8203;1841](googleapis/java-datastore#1841))
([ac393e6](googleapis/java-datastore@ac393e6))
- Update googleapis/sdk-platform-java action to v2.57.0
([#&#8203;1842](googleapis/java-datastore#1842))
([0745906](googleapis/java-datastore@0745906))

</details>

<details>
<summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary>

###
[`v1.49.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.49.0):
1.49.0

### Components

#### Configuration at Runtime

- ✨ Add process tags as list to remote config payload
([#&#8203;8705](DataDog/dd-trace-java#8705) -
[@&#8203;amarziali](https://github.com/amarziali))

#### Continuous Integration Visibility

- 🐛 Add span propagation for Pekko scheduled tasks
([#&#8203;8765](DataDog/dd-trace-java#8765) -
[@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog))
- ✨ Update test.retry_reason to use full name of the feature
([#&#8203;8689](DataDog/dd-trace-java#8689) -
[@&#8203;daniel-mohedano](https://github.com/daniel-mohedano))
- 🧹 Remove unused TestEventsHandler methods
([#&#8203;8674](DataDog/dd-trace-java#8674) -
[@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog))

#### Dynamic Instrumentation

- 🐛 Fix exclude identifiers normalization
([#&#8203;8742](DataDog/dd-trace-java#8742) -
[@&#8203;jpbempel](https://github.com/jpbempel))
- ✨ Make source file tracking asynchronous
([#&#8203;8684](DataDog/dd-trace-java#8684) -
[@&#8203;jpbempel](https://github.com/jpbempel))
- ✨ Add scope filtering for symbol extraction
([#&#8203;8676](DataDog/dd-trace-java#8676) -
[@&#8203;jpbempel](https://github.com/jpbempel))
- ✨ Add support for [@&#8203;key](https://github.com/key) and
[@&#8203;value](https://github.com/value) for Map filtering
([#&#8203;8669](DataDog/dd-trace-java#8669) -
[@&#8203;jpbempel](https://github.com/jpbempel))

#### Library Injection

- ✨ Add system property to force injection of the tracing
library even though multiple javaagents have been detected
([#&#8203;8697](DataDog/dd-trace-java#8697) -
[@&#8203;cecile75](https://github.com/cecile75))

#### Metrics

- ✨ Allow dogstatsd port to be configurable with
DD_DOGSTATSD_PORT
([#&#8203;8693](DataDog/dd-trace-java#8693) -
[@&#8203;randomanderson](https://github.com/randomanderson))

#### Profiling

- ✨ Bump ddprof-java to 1.25.1
([#&#8203;8750](DataDog/dd-trace-java#8750) -
[@&#8203;jbachorik](https://github.com/jbachorik))
- 🐛 Remove cleanup-on-shutdown for temporary files
([#&#8203;8746](DataDog/dd-trace-java#8746) -
[@&#8203;jbachorik](https://github.com/jbachorik))
- ✨⚡ Replace a regex-based SMAP parser with a hand-crafted
one
([#&#8203;8730](DataDog/dd-trace-java#8730) -
[@&#8203;jbachorik](https://github.com/jbachorik))
- ✨ Improve error reporting on profiler startup
([#&#8203;8714](DataDog/dd-trace-java#8714) -
[@&#8203;jbachorik](https://github.com/jbachorik))
- ✨ Exclude ProxyLeakTask exception from exception profiling
([#&#8203;8666](DataDog/dd-trace-java#8666) -
[@&#8203;jbachorik](https://github.com/jbachorik))
- ✨ Use jvmstat for JDKs 9+ programmatically
([#&#8203;8641](DataDog/dd-trace-java#8641) -
[@&#8203;MattAlp](https://github.com/MattAlp))

#### Telemetry

- ✨ Allow dogstatsd port to be configurable with
DD_DOGSTATSD_PORT
([#&#8203;8693](DataDog/dd-trace-java#8693) -
[@&#8203;randomanderson](https://github.com/randomanderson))
- 🐛 Fix appsec.waf.requests telemetry metric
([#&#8203;8644](DataDog/dd-trace-java#8644) -
[@&#8203;jandro996](https://github.com/jandro996))

#### Tracer core

- ✨ Exclude jackson afterburner dynamic classes from
instrumentation
([#&#8203;8747](DataDog/dd-trace-java#8747) -
[@&#8203;amarziali](https://github.com/amarziali))
- ✨ Introduce Java 8 bytecode bridge for instrumentation API
([#&#8203;8736](DataDog/dd-trace-java#8736) -
[@&#8203;PerfectSlayer](https://github.com/PerfectSlayer))
- ⚡🧹 Use byte-buddy classes optimized for Java8+
([#&#8203;8735](DataDog/dd-trace-java#8735) -
[@&#8203;mcculls](https://github.com/mcculls))
- 🐛 Do not set the hibernate or datanucleus span service name when
disabled
([#&#8203;8727](DataDog/dd-trace-java#8727) -
[@&#8203;ygree](https://github.com/ygree))
- ✨ Update bytebuddy and ASM to support JDK 24
([#&#8203;8720](DataDog/dd-trace-java#8720) -
[@&#8203;sarahchen6](https://github.com/sarahchen6))
- 🐛 Turn off JDK socket support by default
([#&#8203;8715](DataDog/dd-trace-java#8715) -
[@&#8203;mcculls](https://github.com/mcculls))
- 🐛 Log warning when trace buffer overflow occurs
([#&#8203;8712](DataDog/dd-trace-java#8712) -
[@&#8203;ygree](https://github.com/ygree))
- ✨🧪 Introducing an internal integration name
([#&#8203;8708](DataDog/dd-trace-java#8708) -
[@&#8203;amarziali](https://github.com/amarziali))
- ✨ Add process tags to client stats payload
([#&#8203;8704](DataDog/dd-trace-java#8704) -
[@&#8203;amarziali](https://github.com/amarziali))
- ✨ Collect process tags for tracing
([#&#8203;8698](DataDog/dd-trace-java#8698) -
[@&#8203;amarziali](https://github.com/amarziali))
- ✨ Stable Config file: target system properties in
process_arguments and support template variables in YamlParser
([#&#8203;8690](DataDog/dd-trace-java#8690) -
[@&#8203;mtoffl01](https://github.com/mtoffl01))
- ✨⚡ Use prefix trie for proxy ignores
([#&#8203;8678](DataDog/dd-trace-java#8678) -
[@&#8203;amarziali](https://github.com/amarziali))
- ✨ Allow agent to be automatically injected when running aside
Log4J patch agent
([#&#8203;8648](DataDog/dd-trace-java#8648) -
[@&#8203;paullegranddc](https://github.com/paullegranddc))
- ✨ Use jvmstat for JDKs 9+ programmatically
([#&#8203;8641](DataDog/dd-trace-java#8641) -
[@&#8203;MattAlp](https://github.com/MattAlp))

#### Tracer internal logging

- 🐛 Delete print line
([#&#8203;8686](DataDog/dd-trace-java#8686) -
[@&#8203;sarahchen6](https://github.com/sarahchen6))

### Instrumentations

#### Akka instrumentation

- 🐛 Handle reentrant scope cleanup in Akka/Pekko actor
instrumentations
([#&#8203;8722](DataDog/dd-trace-java#8722) -
[@&#8203;mcculls](https://github.com/mcculls))

#### Apache Spark instrumentation

- ✨ Use OpenLineage root parent information to generate trace
id ([#&#8203;8726](DataDog/dd-trace-java#8726)
- [@&#8203;mobuchowski](https://github.com/mobuchowski))
- ✨ Spark job cancellation no longer marks application as
failed
([#&#8203;8701](DataDog/dd-trace-java#8701) -
[@&#8203;paul-laffon-dd](https://github.com/paul-laffon-dd))

#### JDBC instrumentation

- 💡 Add support for sybase tds jdbc driver
([#&#8203;8764](DataDog/dd-trace-java#8764) -
[@&#8203;amarziali](https://github.com/amarziali))

#### Kotlin instrumentation

- 🐛 Take defensive copy of parent scope stack when closing nested
coroutines
([#&#8203;8749](DataDog/dd-trace-java#8749) -
[@&#8203;mcculls](https://github.com/mcculls))

#### Reactor instrumentation

- ✨⚡ Do not inspect reactor context when not needed
([#&#8203;8745](DataDog/dd-trace-java#8745) -
[@&#8203;amarziali](https://github.com/amarziali))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am
every weekday" in timezone Australia/Melbourne, Automerge - At any time
(no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Never, or you tick the rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

GitOrigin-RevId: 795f347ae34d056efc1194c2f606cee7bca1beea
ValentinZakharov added a commit that referenced this pull request May 13, 2025
* Implemented WebSocket support for Netty 4.1

* Let propagate unhandled events and fix tests

* Refactoring

* Refactor netty test and fix instrumentation

* Improved pipeline processing - now you can insert handler in any place

* Fixed helper

* Refactoring

* WebSocket Server support for netty-4.0

* Missing handlers use cases for netty-4.1

* Fixed handlers for netty-4.0

* Tests for netty-4.0

* Refactoring

* WebSocket Server support for netty-3.8

* Tests for netty-3.8

* Spotless

* Fixed tests

* Add profiler env check command to AgentCLI (#8671)

* Remove dependency on bash from crash/oome uploder scripts (#8652)

* Do not apply JUnit 4 instrumentation to MUnit runners (#8675)

* Shutdown CI Visibility test event handlers before tracer (#8677)

* Prevent double reporting of Scalatest events when using SBT with test forking (#8682)

* Fix In-Product when config is empty (#8679)

should not stop the product with empty config

* Expand MUnit runners filter to catch munit.MUnitRunner in JUnit 4 instrumentation (#8683)

* Remove unused TestEventsHandler methods (#8674)

* Delete print line (#8686)

* Exclude ProxyLeakTask exception from exception profiling (#8666)

* Use jvmstat for JDKs 9+ programmatically (#8641)

* Update test.retry_reason to use full name of the feature (#8689)

* Allow dogstatsd port to be configurable with DD_DOGSTATSD_PORT (#8693)

* configurable dogstatsd port

* wait the client handshake

* move netty ws client to interested modules

* Added WebSocket tracing check

---------

Co-authored-by: Andrea Marziali <[email protected]>
Co-authored-by: Jaroslav Bachorik <[email protected]>
Co-authored-by: Nikita Tkachenko <[email protected]>
Co-authored-by: Jean-Philippe Bempel <[email protected]>
Co-authored-by: Daniel Mohedano <[email protected]>
Co-authored-by: Sarah Chen <[email protected]>
Co-authored-by: Matt <[email protected]>
Co-authored-by: Laplie Anderson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: ci visibility Continuous Integration Visibility type: refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants