Skip to content

fix otel sampling inheritance#3718

Closed
mtoffl01 wants to merge 4 commits intomainfrom
mtoff/fix-otel-sampling
Closed

fix otel sampling inheritance#3718
mtoffl01 wants to merge 4 commits intomainfrom
mtoff/fix-otel-sampling

Conversation

@mtoffl01
Copy link
Copy Markdown
Contributor

@mtoffl01 mtoffl01 commented Jul 2, 2025

What does this PR do?

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running golangci-lint run locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@mtoffl01 mtoffl01 mentioned this pull request Jul 2, 2025
7 tasks
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Jul 2, 2025

Benchmarks

Benchmark execution time: 2025-07-03 18:40:20

Comparing candidate commit 1205a4a in PR branch mtoff/fix-otel-sampling with baseline commit ef46958 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@darccio
Copy link
Copy Markdown
Member

darccio commented Aug 26, 2025

@mtoffl01 Shall we close this PR in favour of #3856?

@darccio
Copy link
Copy Markdown
Member

darccio commented Nov 14, 2025

@genesor @mtoffl01 Should we keep this PR?

@darccio
Copy link
Copy Markdown
Member

darccio commented Dec 17, 2025

Closing this PR along with 3917.

@darccio darccio closed this Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants