Closed
Conversation
BenchmarksBenchmark execution time: 2025-07-02 17:54:16 Comparing candidate commit 21ca316 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 1 unstable metrics. scenario:BenchmarkSetTagStringer-24
|
darccio
reviewed
Jun 20, 2025
Comment on lines
+472
to
+473
| t.setLocked(true) | ||
| // t.locked = true |
Member
There was a problem hiding this comment.
@mtoffl01 This causes a deadlock because t is already locked at the beginning of finishedOne.
Co-authored-by: Dario Castañé <dario.castane@datadoghq.com>
Contributor
Author
|
Closing in favor of #3718 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Locks the trace sampling priority when it's been inherited by a parent span context.
Motivation
APMS-15887
Reviewer's Checklist
golangci-lint runlocally.Unsure? Have a question? Request a review!