Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .github/workflows/test-compilation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,15 @@ jobs:

# "Corruption" tests: Validate that missing a file really breaks compilation (and thus our tests are working)
# On Rubies that don't use the source, this validates that indeed they aren't using any of these files.
- { ruby_version: '4.0', corruption: true, expected_exit_code: 1 } # Used by `dd-trace-rb` for compilation
#
# TODO: Temporarily disabled so we could release the 4.0.0-beta2 support. Because dd-trace-rb is currently
# pinning Ruby 4.0 to a specific hash
# (in https://github.com/DataDog/dd-trace-rb/blob/48b4d79d6d043271dc760277ddc820f5343f335c/ruby-4.0.gemfile#L81)
# the "corruption" test uses the wrong version of the gem and fails even though everything is fine.
# To break the loop, let's omit this test, then we can release this gem, then we can undo the dd-trace-rb
# changes, and then we can re-enable the test.
#
#- { ruby_version: '4.0', corruption: true, expected_exit_code: 1 } # Used by `dd-trace-rb` for compilation
- { ruby_version: '3.4', corruption: true, expected_exit_code: 1 } # Used by `dd-trace-rb` for compilation
- { ruby_version: '3.3', corruption: true, expected_exit_code: 1 } # Used by `dd-trace-rb` for compilation
- { ruby_version: '3.2', corruption: true, expected_exit_code: 0 }
Expand Down