[PROF-13115] Temporarily skip broken Ruby 4 test to unblock gem release #20
+9
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?** This PR temporarily disables the "Ruby 4.0 corruption" test that's blocking us from releasing the gem as per <https://github.com/DataDog/datadog-ruby_core_source/actions/runs/20057267656/job/57525327190>. **Motivation:** Release latest version of the gem, including Ruby 4.0.0-beta2 support. **Additional Notes:** The issue in question is caused by dd-trace-rb currently pinning Ruby 4.0 to a specific hash (in https://github.com/DataDog/dd-trace-rb/blob/48b4d79d6d043271dc760277ddc820f5343f335c/ruby-4.0.gemfile#L81). This interacts incorrectly with the "corruption" test, making it use the wrong version of the gem: (This is the output from the `bundle info` right before the test runs showing the wrong version being used for the "Add datadog-ruby_core_source" step, from <https://github.com/DataDog/datadog-ruby_core_source/actions/runs/20057267656/job/57525327190>) ``` * datadog-ruby_core_source (3.4.1 7b95302) Summary: Provide Ruby core source files Homepage: https://github.com/DataDog/datadog-ruby_core_source Path: /usr/local/bundle/bundler/gems/datadog-ruby_core_source-7b95302a593c Reverse Dependencies: datadog (2.23.0) depends on datadog-ruby_core_source (~> 3.4, >= 3.4.1) ``` The expected correct output can be seen in <https://github.com/DataDog/datadog-ruby_core_source/actions/runs/20057267656/job/57525327215>: ``` * datadog-ruby_core_source (3.4.2) Summary: Provide Ruby core source files Homepage: https://github.com/DataDog/datadog-ruby_core_source Path: /__w/datadog-ruby_core_source/datadog-ruby_core_source/datadog-ruby_core_source Reverse Dependencies: datadog (2.23.0) depends on datadog-ruby_core_source (~> 3.4, >= 3.4.1) ``` This messup makes CI fail even though everything is fine. This is a loop: dd-trace-rb requires the pinning BECAUSE we haven't released this gem yet. So to break the loop, let's: 1. omit this test temporarily 2. then we can release this gem 3. then we can undo the dd-trace-rb pinning 4. then we can re-enable the test This PR is step 1. I'll take care of all 4 ;) P.s.: Why didn't we see this before? That's because the dd-trace-rb pinning was not there when we initially added the 4.0.0-preview2 headers in #19. Then the pinning was added on the dd-trace-rb side and it silently created this problem for datadog-ruby_core_source CI. **How to test the change?** CI should be green after this change.
Strech
approved these changes
Dec 9, 2025
ivoanjo
added a commit
that referenced
this pull request
Dec 9, 2025
…em release" **What does this PR do?** This reverts commit 551b5ae from #20. See #20 for details. In that PR I mentioned: So to break the loop, let's: 1. omit this test temporarily: ✅ done -> this was #20 2. then we can release this gem: ✅ done -> https://github.com/DataDog/datadog-ruby_core_source/actions/runs/20059401843, [version 3.4.2 is on rubygems.org](https://rubygems.org/gems/datadog-ruby_core_source/versions/3.4.2) 3. then we can undo the dd-trace-rb pinning: ✅ done -> DataDog/dd-trace-rb#5122 4. then we can re-enable the test This PR is step 4 and gets us back to where we were before the workaround. **Motivation:** Remove workaround now that it's not needed anymore! **Additional Notes:** N/A **How to test the change?** Validate that Ruby 4.0 + "corruption" test is running in CI and green.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR temporarily disables the "Ruby 4.0 corruption" test that's blocking us from releasing the gem as per
https://github.com/DataDog/datadog-ruby_core_source/actions/runs/20057267656/job/57525327190.
Motivation:
Release latest version of the gem, including Ruby 4.0.0-beta2 support.
Additional Notes:
The issue in question is caused by dd-trace-rb currently pinning Ruby 4.0 to a specific hash
(in https://github.com/DataDog/dd-trace-rb/blob/48b4d79d6d043271dc760277ddc820f5343f335c/ruby-4.0.gemfile#L81).
This interacts incorrectly with the "corruption" test, making it use the wrong version of the gem:
(This is the output from the
bundle inforight before the test runs showing the wrong version being used for the "Adddatadog-ruby_core_source" step, from
https://github.com/DataDog/datadog-ruby_core_source/actions/runs/20057267656/job/57525327190)
The expected correct output can be seen in
https://github.com/DataDog/datadog-ruby_core_source/actions/runs/20057267656/job/57525327215:
This messup makes CI fail even though everything is fine.
This is a loop: dd-trace-rb requires the pinning BECAUSE we haven't released this gem yet.
So to break the loop, let's:
This PR is step 1. I'll take care of all 4 ;)
P.s.: Why didn't we see this before? That's because the dd-trace-rb pinning was not there when we initially added the 4.0.0-preview2 headers in #19. Then the pinning was added on the dd-trace-rb side and it silently created this problem for datadog-ruby_core_source CI.
How to test the change?
CI should be green after this change.