Skip to content

Fix glog logger conflict #1310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JulienBalestra merged 6 commits into from
Feb 21, 2018
Merged

Fix glog logger conflict #1310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e1ab357
moving glog flag parsing to start of the agent to avoid conflict of l…
Feb 20, 2018
f1aab82
solution to the allow the puppy agent to build
Feb 20, 2018
7a0da01
applying Parse magic trick to the leaderelection
Feb 21, 2018
5bc24ab
relnote for the fix
Feb 21, 2018
672511f
reword reno
xvello Feb 21, 2018
64ea8e6
Fix nit on release note
olivielpeau Feb 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/util/kubernetes/apiserver/leaderelection/leaderelection.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,5 +179,7 @@ func (le *LeaderEngine) IsLeader() bool {
func init() {
// Avoid logging glog from the k8s.io package
flag.Lookup("stderrthreshold").Value.Set("FATAL")
flag.Parse()
//Convinces goflags that we have called Parse() to avoid noisy logs.
//OSS Issue: kubernetes/kubernetes#17162.
flag.CommandLine.Parse([]string{})
}
5 changes: 5 additions & 0 deletions releasenotes/notes/fix-logger-glog-80cfbb7958da4c64.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
fixes:
- |
Fix the command-line flag parsing regression caused by a transitive dependency importing the
glog library. `agent` flags should now behave as in beta9.