Merged
Conversation
CharlyF
force-pushed
the
charly/flag_parse_override
branch
from
3ea15d1 to
34e09ab
Compare
CharlyF
force-pushed
the
charly/flag_parse_override
branch
from
34e09ab to
f1aab82
Compare
mfpierre
reviewed
Feb 21, 2018
| --- | ||
| fixes: | ||
| - | | ||
| Remove the flag.Parse() to use a fix avoiding to overide the logger. |
Member
There was a problem hiding this comment.
could we make this relnote more user-oriented? (i.e. link this fix to a bug in behavior that users may have experienced earlier)
Something like Fix setup of command-line options on the main `agent` command (this may need re-wording too). Let me know what you think
mfpierre
previously approved these changes
Feb 21, 2018
Contributor
mfpierre
left a comment
mfpierre
left a comment
There was a problem hiding this comment.
one nitpick but LGTM
glog was definitively not meant to be vendored 😑
xvello
dismissed stale reviews from JulienBalestra, mfpierre, and masci
via
672511f
olivielpeau
approved these changes
Feb 21, 2018
Member
olivielpeau
left a comment
olivielpeau
left a comment
There was a problem hiding this comment.
Let's merge as soon as the CI passes
mightyguava
added a commit
to mightyguava/datadog-agent
that referenced
this pull request
Jun 27, 2022
The dgraph version of the library is abandoned and the outcaste-io one is now the official fork. The new version removes a dependency on the glog library, that can cause conflicts due to global initialization, see outcaste-io/ristretto#3. The same glog library has caused issues in this repo in the past as well DataDog#1310.
mightyguava
added a commit
to mightyguava/datadog-agent
that referenced
this pull request
Jun 29, 2022
The dgraph version of the library is abandoned and the outcaste-io one is now the official fork. The new version removes a dependency on the glog library, that can cause conflicts due to global initialization, see outcaste-io/ristretto#3. The same glog library has caused issues in this repo in the past as well DataDog#1310.
mightyguava
added a commit
to mightyguava/datadog-agent
that referenced
this pull request
Jun 29, 2022
The dgraph version of the library is abandoned and the outcaste-io one is now the official fork. The new version removes a dependency on the glog library, that can cause conflicts due to global initialization, see outcaste-io/ristretto#3. The same glog library has caused issues in this repo in the past as well DataDog#1310.
mightyguava
added a commit
to mightyguava/datadog-agent
that referenced
this pull request
Jun 29, 2022
The dgraph version of the library is abandoned and the outcaste-io one is now the official fork. The new version removes a dependency on the glog library, that can cause conflicts due to global initialization, see outcaste-io/ristretto#3. The same glog library has caused issues in this repo in the past as well DataDog#1310.
mightyguava
added a commit
to mightyguava/datadog-agent
that referenced
this pull request
Jul 11, 2022
The dgraph version of the library is abandoned and the outcaste-io one is now the official fork. The new version removes a dependency on the glog library, that can cause conflicts due to global initialization, see outcaste-io/ristretto#3. The same glog library has caused issues in this repo in the past as well DataDog#1310.
mightyguava
added a commit
to mightyguava/datadog-agent
that referenced
this pull request
Jul 13, 2022
The dgraph version of the library is abandoned and the outcaste-io one is now the official fork. The new version removes a dependency on the glog library, that can cause conflicts due to global initialization, see outcaste-io/ristretto#3. The same glog library has caused issues in this repo in the past as well DataDog#1310.
gbbr
pushed a commit
that referenced
this pull request
Jul 15, 2022
…12559) The dgraph version of the library is abandoned and the outcaste-io one is now the official fork. The new version removes a dependency on the glog library, that can cause conflicts due to global initialization, see outcaste-io/ristretto#3. The same glog library has caused issues in this repo in the past as well #1310.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
moving glog flag parsing to the start of the agent to avoid conflict of loggers
Rely on an official fix from kubernetes/kubernetes#17162.
Motivation
Not seeing glog errors when the kubernetes client is used.
Having the correct help output when using
./agentwith an incorrect command.