Skip to content

Conversation

@philipanda
Copy link
Contributor

No description provided.

@philipanda philipanda force-pushed the fuzzysearch branch 3 times, most recently from ce5d6d5 to 331d753 Compare August 5, 2025 07:49
@philipanda philipanda changed the title requirements.txt: bump robotframework and telnetlib to add fuzzysearch fuzzysearch Aug 5, 2025
@macpijan
Copy link
Contributor

macpijan commented Aug 5, 2025

I would add some comments and/or commit messages to the commits changing kwds to fuzzy versions. To explain (link) to the original issue and why we changed those instances, not the others.

@wiktormowinski
Copy link
Contributor

image

Any attempt to use this new keyword ends with this error. Even tried recloning osfv.

@philipanda
Copy link
Contributor Author

image

Any attempt to use this new keyword ends with this error. Even tried recloning osfv.

Could I ask for the whole log? This error has never happened to me. Everything works when I'm cloning a fresh copy of OSFV too.

@philipanda philipanda force-pushed the fuzzysearch branch 3 times, most recently from 5fca563 to 6606e5d Compare August 6, 2025 08:42
@philipanda philipanda requested a review from matmacieje August 6, 2025 11:10
@matmacieje
Copy link
Contributor

Tested with dasharo-security/me-neuter.robot, some tests PASSed.

0_9_0_rc3_me-neuter_2025_08_06_12_39_48.zip

@philipanda
Copy link
Contributor Author

Tested with dasharo-security/me-neuter.robot, some tests PASSed.

0_9_0_rc3_me-neuter_2025_08_06_12_39_48.zip

I've added some logging to the library, and to my suprise it didn't appear in the logs from the CI. It does in the @matmacieje's logs. This suggests that CI does not use the exact robotframework versions given in requirements.txt. Some weird caching must be happening.

@macpijan
Copy link
Contributor

Rebased

@macpijan
Copy link
Contributor

macpijan commented Aug 19, 2025

Could I ask for the whole log?

@wiktormowinski Please do provide logs instead of screenshots. It slows us down with the decision here.

custom-boot-menu-key_log.html

I think I have run into similar issue @philipanda when trying to start a test on nucbox.

@philipanda
Copy link
Contributor Author

philipanda commented Aug 20, 2025

Thanks for the logs @macpijan
I've fixed the issue with the inner library crashing out. Starting from a67ef90 it should work fine now.
serial_stability_log.zip

Make sure to rm -rf the venv, and install the newest requirements.txt

Details:
The package I used for matching the strings is a bit fussy when it comes to the types of its parameters, and possibly has some bug which sometimes initializes one parameter with an invalid default value. Don't really have time to investigate into it more.

@philipanda
Copy link
Contributor Author

philipanda commented Aug 20, 2025

@wiktormowinski @matmacieje @macpijan

Separately defining the total amounts of max insertions: TELNET_FUZZY_MAX_INSERTIONS, and max deletions: TELNET_FUZZY_MAX_DELETIONS was added 390f6f5.

It should be perfectly ready to use now
serial_stability_out.zip

Remember to rm -rf the venv and install the newest requirements.txt before testing

@macpijan
Copy link
Contributor

@philipanda I tried on APU2 with the same error settings as for Novacustom in your MR. Resulting in some failures:
apu-configuration-menu_log.html

Is it the same problem as on @wiktormowinski side being discussed today?

@philipanda
Copy link
Contributor Author

@philipanda I tried on APU2 with the same error settings as for Novacustom in your MR. Resulting in some failures:
apu-configuration-menu_log.html

Is it the same problem as on @wiktormowinski side being discussed today?

No, that's a brand new error 🙃
And it looks like it appears somewhere deep in the fuzzysearch package. Seems like it tries to get a slice using a negative index during the search. I wonder If that's some character encoding issue. Otherwise it beats me why it hasn't appeared before.

@philipanda philipanda force-pushed the fuzzysearch branch 2 times, most recently from 6657131 to 7b87c4e Compare August 21, 2025 10:28
Helps to remove unwanted contents from the parsed menu in case
of connection errors

Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
setting max_errors, max_insertions and max_deletions, but
not max_substitutions allowed for an edge case to trigger
where the fuzzysearch library was crashing.

Changing the interface like that should prevent unhandled
situations

Signed-off-by: Filip Gołaś <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants