-
-
Notifications
You must be signed in to change notification settings - Fork 6
fuzzysearch #988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
fuzzysearch #988
Conversation
ce5d6d5 to
331d753
Compare
|
I would add some comments and/or commit messages to the commits changing kwds to |
5fca563 to
6606e5d
Compare
|
Tested with dasharo-security/me-neuter.robot, some tests PASSed. |
I've added some logging to the library, and to my suprise it didn't appear in the logs from the CI. It does in the @matmacieje's logs. This suggests that CI does not use the exact robotframework versions given in requirements.txt. Some weird caching must be happening. |
4274088 to
3c6e1b5
Compare
|
Rebased |
@wiktormowinski Please do provide logs instead of screenshots. It slows us down with the decision here. I think I have run into similar issue @philipanda when trying to start a test on nucbox. |
be73254 to
a67ef90
Compare
|
Thanks for the logs @macpijan Make sure to Details: |
|
@wiktormowinski @matmacieje @macpijan Separately defining the total amounts of max insertions: TELNET_FUZZY_MAX_INSERTIONS, and max deletions: TELNET_FUZZY_MAX_DELETIONS was added 390f6f5. It should be perfectly ready to use now Remember to |
ab53611 to
fd570db
Compare
|
@philipanda I tried on APU2 with the same error settings as for Novacustom in your MR. Resulting in some failures: Is it the same problem as on @wiktormowinski side being discussed today? |
No, that's a brand new error 🙃 |
6657131 to
7b87c4e
Compare
Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
Helps to remove unwanted contents from the parsed menu in case of connection errors Signed-off-by: Filip Gołaś <[email protected]>
7944a1c to
1d58b11
Compare
Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
setting max_errors, max_insertions and max_deletions, but not max_substitutions allowed for an edge case to trigger where the fuzzysearch library was crashing. Changing the interface like that should prevent unhandled situations Signed-off-by: Filip Gołaś <[email protected]>


No description provided.