Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Dockerfile to Ubuntu 20.04 #141

Merged
merged 2 commits into from
May 6, 2020
Merged

Port Dockerfile to Ubuntu 20.04 #141

merged 2 commits into from
May 6, 2020

Conversation

DangerOnTheRanger
Copy link
Owner

This PR will merge a Dockerfile that uses Ubuntu 20.04 LTS and not Alpine Linux.

@DangerOnTheRanger DangerOnTheRanger marked this pull request as ready for review May 5, 2020 13:11
@DangerOnTheRanger
Copy link
Owner Author

@samip5 This is the solution I was talking about over here. I didn't include libffi-dev, but I started up and tested Maniwani in devmode just fine, both reading and posting threads. I can't fully test with the docker-compose stack due to an outstanding issue with captchouli (that I suspect is almost certainly due to gelbooru changing up something on their end), but I did test everything but posting.

According to at least one of the issues I linked, installing libffi-dev shouldn't be necessary since Ubuntu uses glibc and not musl, but if you or anyone else encounter problems, it'll be easy to add back installation of libffi-dev.

@samip5
Copy link
Contributor

samip5 commented May 5, 2020

@samip5 This is the solution I was talking about over here. I didn't include libffi-dev, but I started up and tested Maniwani in devmode just fine, both reading and posting threads. I can't fully test with the docker-compose stack due to an outstanding issue with captchouli (that I suspect is almost certainly due to gelbooru changing up something on their end), but I did test everything but posting.

According to at least one of the issues I linked, installing libffi-dev shouldn't be necessary since Ubuntu uses glibc and not musl, but if you or anyone else encounter problems, it'll be easy to add back installation of libffi-dev.

Actually I did get it building on dev-mode with alpine but it did require that libffi-dev package to be installed.

@DangerOnTheRanger DangerOnTheRanger merged commit ec26a85 into master May 6, 2020
@DangerOnTheRanger DangerOnTheRanger deleted the ubuntu-docker branch May 6, 2020 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants