-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
could not build Dockerfile #133
Comments
mee too similar error |
That's really wierd, it won't complete npm install while dockerized, but if you try npm install in the maniwani git repo root, it will work. :( |
I fixed the issue, @eizanprime @19morpheus80. If you want to try my branch you can. |
@samip5 Ok I will try ! thank you :) |
Merged @samip5's code - sorry for the radio silence on my end. If you guys confirm the problem as solved I'll go ahead and close the issue. EDIT: I do realize #138 is left unmerged, but it appeared that #132 had a more up-to-date |
Have you gotten around to trying it out,@eizanprime? |
I am retrying right now, struggling with other bugs such as
I'm not very experienced with net stuff yet I guess... |
Overall none of the dockers really build fine for me, I also get package signature errors in the debian update docker build step |
Could you please paste the log here or gist or pastebin, it would help a lot? @eizanprime
It's not supposed to be using Debian, but alpine. |
I will make better logs for the first test docker, here is the error for the docker compose build captchouli is not your docker I guess :// Thank you so much for helping me, I am sorry for having so little time these days
|
So maniwani itself builds right?
|
@eizanprime: My compose build works without any errors so I cannot duplicate your problem.
|
I see, I don't know what the problem could be.. The first dockerfile build fine, except this error, but it still builds
when running tho it fails whith this kind of logs (continues in loop) (I love the swears 😂)
|
Ah, this is one of the run errors that seem to surface from time to time, for some reason gevent is not present in UWSG environment it tries to use. I will take a look at an alternative approach than using UWSGI. |
I see ! Is there any workarounds I can use to make it work ? :) |
@eizanprime Please see #124. I recommend reading the full conversation there. |
I suspect the issue at hand here is Alpine upgrading their Python 3 version under our noses again, as the |
@DangerOnTheRanger Could you elaborate on the "more permanent solution"? I'm going to be working to get it working with a container running passenger. |
Swapping container OSes from Alpine to either Ubuntu (via
The reason why I don't think switching application servers is necessarily the most optimal solution is that it's a symptom of a much larger problem and could come back in a different form later. I also believe swapping the container OS will be less intrusive since outside of a transitive dependency on by way of being built on Alpine (which shouldn't affect any part of a Python application) there's nothing in Maniwani that's Alpine-only. |
This can probably be closed as the Dockerfile is using Ubuntu now? Could @eizanprime and @19morpheus80 verify that this issue could be closed, using the master branch? |
Hello, sorry for my absence regarding this issue. I can confirm the dockerfile in master branch builds without error. I would suggest that the resultant build image could be streamlined somewhat (33 layers and 1.65GB image is suboptimal). Perhaps this is something I or another could send a PR for in due course. Thanks to all who have contributed! |
I think a good approach would be to close this issue and make a new one for the streamlining of the image size? |
I agree the container image as-is is too large; probably the best way to go about it would be to use a multi-stage build after cutting down the layers and then freeze Maniwani itself into a single executable so a completely clean and vanilla base image could be used. I'm taking a stab at all that while I type this; if I don't get it done within a couple hours I'll open up a new issue so someone else can try it out. |
I think this issue has probably run its course - I'm glad that the Dockerfile is working, even if it is too big. We should probably move to #142 for any further discussion on that matter, though. Thanks again to everyone who helped figure this one out! |
I tried to build according to the readme (
docker build -t maniwani-dev --target dev .
) and the npm install failed:The text was updated successfully, but these errors were encountered: