Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Log_Msg_* dtors #2255

Merged
merged 1 commit into from
Jul 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions ACE/ace/Log_Msg_Backend.cpp

This file was deleted.

2 changes: 1 addition & 1 deletion ACE/ace/Log_Msg_Backend.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class ACE_Export ACE_Log_Msg_Backend
{
public:
/// No-op virtual destructor.
virtual ~ACE_Log_Msg_Backend ();
virtual ~ACE_Log_Msg_Backend () = default;

/**
* Open the back end object. Perform any actions needed to prepare
Expand Down
9 changes: 0 additions & 9 deletions ACE/ace/Log_Msg_Callback.cpp

This file was deleted.

2 changes: 1 addition & 1 deletion ACE/ace/Log_Msg_Callback.h
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ class ACE_Export ACE_Log_Msg_Callback
ACE_Log_Msg_Callback () = default;

/// No-op virtual destructor.
virtual ~ACE_Log_Msg_Callback ();
virtual ~ACE_Log_Msg_Callback () = default;

/// Callback routine. This is called when we want to log a message.
/// Since this routine is pure virtual, it must be overwritten by the
Expand Down
10 changes: 5 additions & 5 deletions ACE/ace/Log_Msg_UNIX_Syslog.h
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class ACE_Export ACE_Log_Msg_UNIX_Syslog : public ACE_Log_Msg_Backend
ACE_Log_Msg_UNIX_Syslog () = default;

/// Destructor
virtual ~ACE_Log_Msg_UNIX_Syslog ();
~ACE_Log_Msg_UNIX_Syslog () override;

/// Open a new event log.
/**
Expand All @@ -48,16 +48,16 @@ class ACE_Export ACE_Log_Msg_UNIX_Syslog : public ACE_Log_Msg_Backend
* it is 0 (no name), the application name as
* returned from ACE_Log_Msg::program_name() is used.
*/
virtual int open (const ACE_TCHAR *logger_key);
int open (const ACE_TCHAR *logger_key) override;

/// Reset the backend.
virtual int reset ();
int reset () override;

/// Close the backend completely.
virtual int close ();
int close () override;

/// This is called when we want to log a message.
virtual ssize_t log (ACE_Log_Record &log_record);
ssize_t log (ACE_Log_Record &log_record) override;

private:
/// Convert an ACE_Log_Priority value to the corresponding syslog priority.
Expand Down
2 changes: 0 additions & 2 deletions ACE/ace/ace.mpc
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,6 @@ project(ACE) : ace_output, acedefaults, install, other, codecs, token, svcconf,
Log_Category.cpp
Log_Msg.cpp
Log_Msg_Android_Logcat.cpp
Log_Msg_Backend.cpp
Log_Msg_Callback.cpp
Log_Msg_IPC.cpp
Log_Msg_NT_Event_Log.cpp
Log_Msg_UNIX_Syslog.cpp
Expand Down
2 changes: 0 additions & 2 deletions ACE/ace/ace_for_tao.mpc
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,6 @@ project(ACE_FOR_TAO) : acedefaults, install, svcconf, uuid, versioned_namespace,
Lock.cpp
Log_Category.cpp
Log_Msg.cpp
Log_Msg_Backend.cpp
Log_Msg_Callback.cpp
Log_Msg_IPC.cpp
Log_Msg_NT_Event_Log.cpp
Log_Msg_UNIX_Syslog.cpp
Expand Down
Loading