Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Log_Msg_* dtors #2255

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Default Log_Msg_* dtors #2255

merged 1 commit into from
Jul 25, 2024

Conversation

likema
Copy link
Contributor

@likema likema commented Jul 14, 2024

No description provided.

ACE/ace/Log_Msg_Android_Logcat.h Outdated Show resolved Hide resolved
ACE/ace/Log_Msg_Callback.cpp Outdated Show resolved Hide resolved
@likema likema force-pushed the log-msg-ctors branch 2 times, most recently from c264e59 to b1f2dd6 Compare July 14, 2024 10:28
@jwillemsen
Copy link
Member

Don’t force push braches as it results in more time to review

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks it can be removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@likema
Copy link
Contributor Author

likema commented Jul 14, 2024

Don’t force push braches as it results in more time to review

Sorry, I just wanted to make the commit(s) in this PR as less as possible

@likema likema force-pushed the log-msg-ctors branch 2 times, most recently from a8d6357 to 6b1faf3 Compare July 14, 2024 11:27
@likema likema changed the title Remove empty Log_Msg_* ctors Default Log_Msg_* dtors Jul 14, 2024
@jwillemsen jwillemsen merged commit 56e1769 into DOCGroup:master Jul 25, 2024
43 of 44 checks passed
@likema likema deleted the log-msg-ctors branch July 27, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants