Moves constants to settings.py; #993
#1079
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quantum5
reviewed
Sep 30, 2019
| @@ -312,7 +391,7 @@ | |||
| ENABLE_FTS = False | |||
|
|
|||
| # Bridged configuration | |||
| BRIDGED_JUDGE_ADDRESS = [('localhost', 9999)] | |||
| BRIDGED_JUDGE_ADDRESS = [('localhost', 8080)] | |||
Xyene
reviewed
Sep 30, 2019
| @@ -9,7 +9,7 @@ | |||
| from django.forms.utils import flatatt | |||
| from django.utils.safestring import mark_safe | |||
|
|
|||
| ACE_URL = getattr(settings, 'ACE_URL', '//cdnjs.cloudflare.com/ajax/libs/ace/1.1.3/ext-split.js') | |||
Xyene
reviewed
Sep 30, 2019
| @@ -6,8 +6,8 @@ | |||
| from judge.models import Submission | |||
| from judge.timezone import from_database_time | |||
|
|
|||
| PP_STEP = getattr(settings, 'DMOJ_PP_STEP', 0.95) | |||
| PP_ENTRIES = getattr(settings, 'DMOJ_PP_ENTRIES', 100) | |||
| PP_STEP = settings.DMOJ_PP_STEP | |||
Xyene
reviewed
Sep 30, 2019
| excluded=getattr(settings, 'DMOJ_CAMO_EXCLUDE', ()), | ||
| https=getattr(settings, 'DMOJ_CAMO_HTTPS', False)) | ||
| if settings.DMOJ_CAMO_URL and settings.DMOJ_CAMO_KEY: | ||
| client = CamoClient(settings.DMOJ_CAMO_URL, key = settings.DMOJ_CAMO_KEY, |
Xyene
reviewed
Sep 30, 2019
| @@ -5,4 +5,4 @@ | |||
| else: | |||
| Subscription = None | |||
|
|
|||
| newsletter_id = None if Subscription is None else getattr(settings, 'NEWSLETTER_ID_ON_REGISTER', None) | |||
| newsletter_id = None if Subscription is None else settings.NEWSLETTER_ID_ON_REGISTER | |||
Xyene
reviewed
Sep 30, 2019
judge/widgets/select2.py
Outdated
| 'django_select2.js'), | ||
| css={'screen': (getattr(settings, 'SELECT2_CSS_URL', DEFAULT_SELECT2_CSS),)} | ||
| css={'screen': (settings.SELECT2_CSS_URL)} |
There was a problem hiding this comment.
The original was a tuple; this no longer is.
Xyene
reviewed
Sep 30, 2019
| TERMS_OF_SERVICE_URL = None | ||
| DEFAULT_USER_LANGUAGE = 'PY2' | ||
|
|
||
| COMPRESS_ENABLED = False |
There was a problem hiding this comment.
I guess this should still be not DEBUG.
Xyene
reviewed
Sep 30, 2019
| SITE_ADMIN_EMAIL = False | ||
|
|
||
| # Constants | ||
| DMOJ_SSL = 0 |
There was a problem hiding this comment.
Add comment for what the possible values here are (https://github.com/DMOJ/site/pull/1079/files#diff-43f2be90fc113eb0e09a185fcfc97b69L20)
This will prevent #1058 from causing confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #993